linux-kernel - Re: [PATCH] media: dt-bindings: mediatek: Constrain iommus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e462cdc4-7243-4cef-bd1d-a0ef551b3a87@kernel.org>
Date: Sun, 25 May 2025 12:51:50 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Daniel Stone <daniel@...ishbar.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc: Chun-Kuang Hu <chunkuang.hu@...nel.org>,
 Philipp Zabel <p.zabel@...gutronix.de>, David Airlie <airlied@...il.com>,
 Simona Vetter <simona@...ll.ch>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Matthias Brugger
 <matthias.bgg@...il.com>,
 AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
 dri-devel@...ts.freedesktop.org, linux-mediatek@...ts.infradead.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] media: dt-bindings: mediatek: Constrain iommus

On 25/05/2025 12:48, Daniel Stone wrote:
> On Sun, 25 May 2025 at 06:16, Krzysztof Kozlowski
> <krzysztof.kozlowski@...aro.org> wrote:
>> --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,ovl-2l.yaml
>> +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,ovl-2l.yaml
>> @@ -45,9 +45,8 @@ properties:
>>        - description: OVL-2L Clock
>>
>>    iommus:
>> -    description:
>> -      This property should point to the respective IOMMU block with master port as argument,
>> -      see Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml for details.
>> +    minItems: 1
>> +    maxItems: 2
> 
> The comment removals are not documented in the commit message, and
> it's not clear why removing information and references would be a good
> thing.
It's obvious, isn't? The consumer shall not define which provider has to
use or how many cells provider has.

Best regards,
Krzysztof