linux-kernel - Re: [PATCH v6 5/6] iio: adc: ad7606: exit for invalid fdt dt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250525150126.0f38696f@jic23-huawei>
Date: Sun, 25 May 2025 15:01:26 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: Angelo Dureghello <adureghello@...libre.com>
Cc: David Lechner <dlechner@...libre.com>, Nuno Sá
 <nuno.sa@...log.com>, Andy Shevchenko <andy@...nel.org>, Lars-Peter Clausen
 <lars@...afoo.de>, Michael Hennerich <Michael.Hennerich@...log.com>, Rob
 Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor
 Dooley <conor+dt@...nel.org>, linux-iio@...r.kernel.org,
 linux-kernel@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH v6 5/6] iio: adc: ad7606: exit for invalid fdt dt_schema
 properties

On Thu, 22 May 2025 15:27:06 +0200
Angelo Dureghello <adureghello@...libre.com> wrote:

> From: Angelo Dureghello <adureghello@...libre.com>
> 
> Fix ad7606_get_chan_config() fdt parsing function to exit for error in
> case of invalid dt_schema values.
> 
> Idea is to not allowing to proceed over when there are values that are
> not allowed from the dt_schema.

"Idea is to not proceed when there are values that are not allowed
under the dt_shema."

> 
> Fixes: f3838e934dff ("iio: adc: ad7606: add support for AD7606C-{16,18} parts")

I'm in favour of consistency but it's only a 'fix' in the sense of blocking
bad DT cleanly.  So I don't think the Fixes tag is appropriate here.

> Signed-off-by: Angelo Dureghello <adureghello@...libre.com>

> ---
>  drivers/iio/adc/ad7606.c | 10 ++++------
>  1 file changed, 4 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/iio/adc/ad7606.c b/drivers/iio/adc/ad7606.c
> index bb0c89fc618874f4a5948d8e537716f87127bc92..f832fd0daf50a69a892636018bda2e43f73d1570 100644
> --- a/drivers/iio/adc/ad7606.c
> +++ b/drivers/iio/adc/ad7606.c
> @@ -319,15 +319,13 @@ static int ad7606_get_chan_config(struct iio_dev *indio_dev, int ch,
>  
>  		ret = fwnode_property_read_u32(child, "reg", &reg);
>  		if (ret)
> -			continue;
> +			return ret;
>  
>  		/* channel number (here) is from 1 to num_channels */
> -		if (reg < 1 || reg > num_channels) {
> -			dev_warn(dev,
> -				 "Invalid channel number (ignoring): %d\n", reg);
> -			continue;
> -		}
> +		if (reg < 1 || reg > num_channels)
> +			return -EINVAL;
>  
> +		/* Loop until we are in the right channel. */
>  		if (reg != (ch + 1))
>  			continue;
>  
>