linux-kernel - Re: [PATCH 1/2] iio: adc: ad4080: use lowercase device name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250525151118.1384a139@jic23-huawei>
Date: Sun, 25 May 2025 15:11:18 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: Nuno Sá <noname.nuno@...il.com>
Cc: Antoniu Miclaus <antoniu.miclaus@...log.com>, linux-iio@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] iio: adc: ad4080: use lowercase device name

On Tue, 20 May 2025 15:08:52 +0100
Nuno Sá <noname.nuno@...il.com> wrote:

> On Tue, 2025-05-20 at 14:01 +0300, Antoniu Miclaus wrote:
> > Update the .name field in the ad4080_chip_info struct
> > from "AD4080" to "ad4080" to follow the common convention
> > in IIO drivers of using lowercase names for device identifiers.
> > 
> > No functional changes are introduced.
Isn't this what is read back from /sys/bus/iio/devices/iio\:device0/name?

changing it is a functional change.  I'd argue it's a fix and deserved
a fixed tag.

> > 
> > Signed-off-by: Antoniu Miclaus <antoniu.miclaus@...log.com>
> > ---  
> 
> Reviewed-by: Nuno Sá <nuno.sa@...log.com>
> 
> >  drivers/iio/adc/ad4080.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/iio/adc/ad4080.c b/drivers/iio/adc/ad4080.c
> > index e8b2e5e7a68a..c36eb41d738a 100644
> > --- a/drivers/iio/adc/ad4080.c
> > +++ b/drivers/iio/adc/ad4080.c
> > @@ -433,7 +433,7 @@ static const struct iio_chan_spec ad4080_channel = {
> >  };
> >  
> >  static const struct ad4080_chip_info ad4080_chip_info = {
> > -	.name = "AD4080",
> > +	.name = "ad4080",
> >  	.product_id = AD4080_CHIP_ID,
> >  	.scale_table = ad4080_scale_table,
> >  	.num_scales = ARRAY_SIZE(ad4080_scale_table),  
>