linux-kernel - Re: [PATCH] rust: list: fix path of `assert

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <DA5FBED7E1NX.W675V3MKQSMD@kernel.org>
Date: Sun, 25 May 2025 19:39:04 +0200
From: "Benno Lossin" <lossin@...nel.org>
To: "Miguel Ojeda" <ojeda@...nel.org>, "Alex Gaynor"
 <alex.gaynor@...il.com>, "Boqun Feng" <boqun.feng@...il.com>, "Gary Guo"
 <gary@...yguo.net>, Björn Roy Baron
 <bjorn3_gh@...tonmail.com>, "Benno Lossin" <lossin@...nel.org>, "Andreas
 Hindborg" <a.hindborg@...nel.org>, "Alice Ryhl" <aliceryhl@...gle.com>,
 "Trevor Gross" <tmgross@...ch.edu>, "Danilo Krummrich" <dakr@...nel.org>,
 "Fiona Behrens" <me@...enk.dev>, "Xiangfei Ding"
 <dingxiangfei2009@...il.com>
Cc: <stable@...nel.org>, <rust-for-linux@...r.kernel.org>,
 <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] rust: list: fix path of `assert_pinned!`

On Sun May 25, 2025 at 7:34 PM CEST, Benno Lossin wrote:
> Commit dbd5058ba60c ("rust: make pin-init its own crate") moved all
> items from pin-init into the pin-init crate, including the
> `assert_pinned!` macro.
>
> Thus fix the path.
>
> This occurrence was missed in that commit, since it has no current
> users, although binder does.

Aw damn, I edited the message, but forgot to regenerate the .patch
file... here is the edited version:

    Commit dbd5058ba60c ("rust: make pin-init its own crate") moved all
    items from pin-init into the pin-init crate, including the
    `assert_pinned!` macro.
    
    Thus fix the path of the sole user of the `assert_pinned!` macro.
    
    This occurrence was missed in the commit above, since it is in a macro
    has no current users (although binder is a future user).

---
Cheers,
Benno

> Cc: stable@...nel.org # I haven't found the commit in stable yet, but just to be sure.
> Fixes: dbd5058ba60c ("rust: make pin-init its own crate")
> Signed-off-by: Benno Lossin <lossin@...nel.org>
> ---
>  rust/kernel/list/arc.rs | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/rust/kernel/list/arc.rs b/rust/kernel/list/arc.rs
> index 13c50df37b89..a88a2dc65aa7 100644
> --- a/rust/kernel/list/arc.rs
> +++ b/rust/kernel/list/arc.rs
> @@ -96,7 +96,7 @@ unsafe fn on_drop_list_arc(&self) {}
>      } $($rest:tt)*) => {
>          impl$(<$($generics)*>)? $crate::list::ListArcSafe<$num> for $t {
>              unsafe fn on_create_list_arc_from_unique(self: ::core::pin::Pin<&mut Self>) {
> -                $crate::assert_pinned!($t, $field, $fty, inline);
> +                ::pin_init::assert_pinned!($t, $field, $fty, inline);
>  
>                  // SAFETY: This field is structurally pinned as per the above assertion.
>                  let field = unsafe {
>
> base-commit: f26449565019315650c9fe87743b10103910ca6b