linux-kernel - Re: [PATCH v2 04/14] x86: Handle KCOV _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ba4f4fd0-1bcf-3d84-c08e-ba0dd040af16@linux.intel.com>
Date: Mon, 26 May 2025 00:53:13 +0300 (EEST)
From: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To: Kees Cook <kees@...nel.org>
cc: Arnd Bergmann <arnd@...db.de>, Thomas Gleixner <tglx@...utronix.de>, 
    Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>, 
    Dave Hansen <dave.hansen@...ux.intel.com>, x86@...nel.org, 
    "H. Peter Anvin" <hpa@...or.com>, Paolo Bonzini <pbonzini@...hat.com>, 
    Vitaly Kuznetsov <vkuznets@...hat.com>, 
    Henrique de Moraes Holschuh <hmh@....eng.br>, 
    Hans de Goede <hdegoede@...hat.com>, 
    "Rafael J. Wysocki" <rafael@...nel.org>, Len Brown <lenb@...nel.org>, 
    Masami Hiramatsu <mhiramat@...nel.org>, Ard Biesheuvel <ardb@...nel.org>, 
    Mike Rapoport <rppt@...nel.org>, 
    Michal Wilczynski <michal.wilczynski@...el.com>, 
    Juergen Gross <jgross@...e.com>, 
    Andy Shevchenko <andriy.shevchenko@...ux.intel.com>, 
    "Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>, 
    Roger Pau Monne <roger.pau@...rix.com>, 
    David Woodhouse <dwmw@...zon.co.uk>, Usama Arif <usama.arif@...edance.com>, 
    "Guilherme G. Piccoli" <gpiccoli@...lia.com>, 
    Thomas Huth <thuth@...hat.com>, Brian Gerst <brgerst@...il.com>, 
    kvm@...r.kernel.org, ibm-acpi-devel@...ts.sourceforge.net, 
    platform-driver-x86@...r.kernel.org, linux-acpi@...r.kernel.org, 
    linux-trace-kernel@...r.kernel.org, linux-efi@...r.kernel.org, 
    linux-mm@...ck.org, "Gustavo A. R. Silva" <gustavoars@...nel.org>, 
    Christoph Hellwig <hch@....de>, Marco Elver <elver@...gle.com>, 
    Andrey Konovalov <andreyknvl@...il.com>, 
    Andrey Ryabinin <ryabinin.a.a@...il.com>, 
    Masahiro Yamada <masahiroy@...nel.org>, 
    Nathan Chancellor <nathan@...nel.org>, 
    Nicolas Schier <nicolas.schier@...ux.dev>, 
    Nick Desaulniers <nick.desaulniers+lkml@...il.com>, 
    Bill Wendling <morbo@...gle.com>, Justin Stitt <justinstitt@...gle.com>, 
    LKML <linux-kernel@...r.kernel.org>, kasan-dev@...glegroups.com, 
    linux-doc@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, 
    kvmarm@...ts.linux.dev, linux-riscv@...ts.infradead.org, 
    linux-s390@...r.kernel.org, linux-hardening@...r.kernel.org, 
    linux-kbuild@...r.kernel.org, linux-security-module@...r.kernel.org, 
    linux-kselftest@...r.kernel.org, sparclinux@...r.kernel.org, 
    llvm@...ts.linux.dev
Subject: Re: [PATCH v2 04/14] x86: Handle KCOV __init vs inline mismatches

On Thu, 22 May 2025, Kees Cook wrote:

> When KCOV is enabled all functions get instrumented, unless the
> __no_sanitize_coverage attribute is used. To prepare for
> __no_sanitize_coverage being applied to __init functions, we have to
> handle differences in how GCC's inline optimizations get resolved. For
> x86 this means forcing several functions to be inline with
> __always_inline.
> 
> Signed-off-by: Kees Cook <kees@...nel.org>
> ---
> Cc: Thomas Gleixner <tglx@...utronix.de>
> Cc: Ingo Molnar <mingo@...hat.com>
> Cc: Borislav Petkov <bp@...en8.de>
> Cc: Dave Hansen <dave.hansen@...ux.intel.com>
> Cc: <x86@...nel.org>
> Cc: "H. Peter Anvin" <hpa@...or.com>
> Cc: Paolo Bonzini <pbonzini@...hat.com>
> Cc: Vitaly Kuznetsov <vkuznets@...hat.com>
> Cc: Henrique de Moraes Holschuh <hmh@....eng.br>
> Cc: Hans de Goede <hdegoede@...hat.com>
> Cc: "Ilpo Järvinen" <ilpo.jarvinen@...ux.intel.com>
> Cc: "Rafael J. Wysocki" <rafael@...nel.org>
> Cc: Len Brown <lenb@...nel.org>
> Cc: Masami Hiramatsu <mhiramat@...nel.org>
> Cc: Ard Biesheuvel <ardb@...nel.org>
> Cc: Mike Rapoport <rppt@...nel.org>
> Cc: Michal Wilczynski <michal.wilczynski@...el.com>
> Cc: Juergen Gross <jgross@...e.com>
> Cc: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> Cc: "Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>
> Cc: Roger Pau Monne <roger.pau@...rix.com>
> Cc: David Woodhouse <dwmw@...zon.co.uk>
> Cc: Usama Arif <usama.arif@...edance.com>
> Cc: "Guilherme G. Piccoli" <gpiccoli@...lia.com>
> Cc: Thomas Huth <thuth@...hat.com>
> Cc: Brian Gerst <brgerst@...il.com>
> Cc: <kvm@...r.kernel.org>
> Cc: <ibm-acpi-devel@...ts.sourceforge.net>
> Cc: <platform-driver-x86@...r.kernel.org>
> Cc: <linux-acpi@...r.kernel.org>
> Cc: <linux-trace-kernel@...r.kernel.org>
> Cc: <linux-efi@...r.kernel.org>
> Cc: <linux-mm@...ck.org>
> ---

> diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c
> index e7350c9fa3aa..0518d5b1f4ec 100644
> --- a/drivers/platform/x86/thinkpad_acpi.c
> +++ b/drivers/platform/x86/thinkpad_acpi.c
> @@ -559,12 +559,12 @@ static unsigned long __init tpacpi_check_quirks(
>  	return 0;
>  }
>  
> -static inline bool __pure __init tpacpi_is_lenovo(void)
> +static __always_inline bool __pure tpacpi_is_lenovo(void)
>  {
>  	return thinkpad_id.vendor == PCI_VENDOR_ID_LENOVO;
>  }
>  
> -static inline bool __pure __init tpacpi_is_ibm(void)
> +static __always_inline bool __pure tpacpi_is_ibm(void)
>  {
>  	return thinkpad_id.vendor == PCI_VENDOR_ID_IBM;
>  }

Hi Kees,

What's your plan on upstreaming route/timeline for this? I'd prefer to 
retain full control over this file as we were planning on some 
reorganization of files into lenovo/ subdir.


-- 
 i.