linux-kernel - Re: [PATCH v11 0/6] platform/x86: Add Lenovo WMI Gaming Series Drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <755BCB57-A912-44BF-AD6C-6B9AFA33A340@gmail.com>
Date: Sun, 25 May 2025 15:31:29 -0700
From: "Derek J. Clark" <derekjohn.clark@...il.com>
To: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
CC: Hans de Goede <hdegoede@...hat.com>, Armin Wolf <W_Armin@....de>,
 Jonathan Corbet <corbet@....net>, Mario Limonciello <superm1@...nel.org>,
 Luke Jones <luke@...nes.dev>, Xino Ni <nijs1@...ovo.com>,
 Zhixin Zhang <zhangzx36@...ovo.com>, Mia Shao <shaohz1@...ovo.com>,
 Mark Pearson <mpearson-lenovo@...ebb.ca>,
 "Pierre-Loup A . Griffais" <pgriffais@...vesoftware.com>,
 "Cody T . -H . Chiu" <codyit@...il.com>, John Martens <johnfanv2@...il.com>,
 Kurt Borja <kuurtb@...il.com>, platform-driver-x86@...r.kernel.org,
 linux-doc@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v11 0/6] platform/x86: Add Lenovo WMI Gaming Series Drivers

On May 25, 2025 2:41:51 PM PDT, "Ilpo Järvinen" <ilpo.jarvinen@...ux.intel.com> wrote:
>On Mon, 26 May 2025, Ilpo Järvinen wrote:
>
>> On Wed, 21 May 2025, Derek J. Clark wrote:
>> 
>> > Adds support for the Lenovo "Gaming Series" of laptop hardware that use
>> > WMI interfaces that control various power settings. There are multiple WMI
>> > interfaces that work in concert to provide getting and setting values as
>> > well as validation of input. Currently only the "Gamezone", "Other
>> > Mode", and "LENOVO_CAPABILITY_DATA_01" interfaces are implemented, but
>> > I attempted to structure the driver so that adding the "Custom Mode",
>> > "Lighting", and other data block interfaces would be trivial in later
>> > patches.
>> > 
>> > This driver attempts to standardize the exposed sysfs by mirroring the
>> > asus-armoury driver currently under review. As such, a lot of
>> > inspiration has been drawn from that driver.
>> > https://lore.kernel.org/platform-driver-x86/20250319065827.53478-1-luke@ljones.dev/#t
>> > 
>> > The drivers have been tested by me on the Lenovo Legion Go and Legion Go
>> > S.
>> > 
>> > Suggested-by: Mario Limonciello <superm1@...nel.org>
>> > Reviewed-by: Armin Wolf <W_Armin@....de>
>> > Signed-off-by: Derek J. Clark <derekjohn.clark@...il.com>
>> > ---
>> > v11:
>> >   - Fix formmating issues.
>> 
>> Thanks for the update, I've applied this now into the review-ilpo-next 
>> branch. BUT, this is very late in the cycle now and if there's a build 
>> issue (or LKP doesn't build test it in reasonable time), I'll have to drop 
>> this series and postpone it into the next cycle as I don't want to delay 
>> the main PR to Linus too long.
>> 
>> But lets hope for the best, I think some depends on issues were fixed 
>> earlier (IIRC), so hopefully it works good enough now. :-)

>Hmpf, these give me a few new warnings related to this series:
>
>make W=1 drivers/platform/x86/
>make C=2 drivers/platform/x86/
>
>...I really don't know why sparse complains about the lock context 
>imbalance though, those functions use guard().

Hmm, I'll take a look at it.

Is there a comprehensive list of all tests that need to be run? I'd like to improve my process to avoid these in the future.

>There's also a copy-paste error:
>
> * lwmi_gz_profile_get_get() - Get the current platform profile.
>
>..._get_get -> ..._set
>Get -> Set

Do you want me to submit v12 whenever it's ready,  or wait for the merge window to open? Trying to avoid too much noise on your end.

Thanks,
- Derek