linux-kernel - Re: [PATCH v6 3/9] rust: device: Add property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <874ix8num4.fsf@posteo.net>
Date: Sun, 25 May 2025 23:19:54 +0000
From: Charalampos Mitrodimas <charmitro@...teo.net>
To: Remo Senekowitsch <remo@...nzli.dev>
Cc: Rob Herring <robh@...nel.org>, Saravana Kannan <saravanak@...gle.com>,
 Miguel Ojeda <ojeda@...nel.org>, Alex Gaynor <alex.gaynor@...il.com>,
 Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>,
 Björn Roy
 Baron <bjorn3_gh@...tonmail.com>, Benno Lossin <lossin@...nel.org>,
 Andreas Hindborg <a.hindborg@...nel.org>, Alice Ryhl
 <aliceryhl@...gle.com>, Trevor Gross <tmgross@...ch.edu>, Danilo Krummrich
 <dakr@...nel.org>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 "Rafael J. Wysocki" <rafael@...nel.org>, Dirk Behme
 <dirk.behme@...bosch.com>, linux-kernel@...r.kernel.org,
 devicetree@...r.kernel.org, rust-for-linux@...r.kernel.org
Subject: Re: [PATCH v6 3/9] rust: device: Add property_present() to FwNode

Remo Senekowitsch <remo@...nzli.dev> writes:

> The new FwNode abstraction will be used for accessing all device
> properties, so it must have the property_present method.
>
> It's possible to duplicate the methods on the device itself, but since
> some of the methods on Device would have different type sigatures as
> the ones on FwNode, this would only lead to inconsistency and confusion.
> So, in the future, property_perent will be removed from Device. However,

Hi Remo!

Spotted a typo, property_present.

--
C. Mitrodimas

> there's a user about to be merged, so the method is left to make merging
> easier.
>
> Signed-off-by: Remo Senekowitsch <remo@...nzli.dev>
> ---
>  rust/kernel/device/property.rs | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/rust/kernel/device/property.rs b/rust/kernel/device/property.rs
> index ca525ed0e8e8f..71a0605b8ecad 100644
> --- a/rust/kernel/device/property.rs
> +++ b/rust/kernel/device/property.rs
> @@ -6,7 +6,7 @@
>  
>  use core::ptr;
>  
> -use crate::{bindings, types::Opaque};
> +use crate::{bindings, str::CStr, types::Opaque};
>  
>  /// A reference-counted fwnode_handle.
>  ///
> @@ -31,6 +31,12 @@ impl FwNode {
>      pub(crate) fn as_raw(&self) -> *mut bindings::fwnode_handle {
>          self.0.get()
>      }
> +
> +    /// Checks if property is present or not.
> +    pub fn property_present(&self, name: &CStr) -> bool {
> +        // SAFETY: By the invariant of `CStr`, `name` is null-terminated.
> +        unsafe { bindings::fwnode_property_present(self.as_raw().cast_const(), name.as_char_ptr()) }
> +    }
>  }
>  
>  // SAFETY: Instances of `FwNode` are always reference-counted.