linux-kernel - [PATCH v4] staging: rtl8723bs: Fix camelCase to snake

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20250525064426.9662-1-donnyturizo13@gmail.com>
Date: Sun, 25 May 2025 06:44:25 +0000
From: Donny Turizo <donnyturizo13@...il.com>
To: gregkh@...uxfoundation.org
Cc: linux-staging@...ts.linux.dev,
	linux-kernel@...r.kernel.org,
	Donny Turizo <donnyturizo13@...il.com>
Subject: [PATCH v4] staging: rtl8723bs: Fix camelCase to snake_case style in core files

This patch renames functions _Read_Macreg and _Write_Macreg to
_read_macreg and _write_macreg respectively, aligning them with the
Linux kernel naming convention of using snake_case for identifiers.

These Changes improve code readability and maintain consistency with
the kernel coding style, particulary in the rtl8723bs staging driver.

No functional changes introduced.

Signed-off-by: Donny Turizo <donnyturizo13@...il.com>

---
v2: Corrected the base branch used for the patch.

v3: Rebased onto a branch not maintained by Greg Kroah-Hartmant.
Also updated the commit message body, changed the "From" field to my
real name, and updated the Signed-off-by line accordingly.

v4: Rebased properly onto Greg Kroah-Hartman staging tree to ensure
correct upstream submission.

In v2, the patch was rebased onto the correct tree, but in v3 it was
rebased onto a branch not maintained by Greg Kroah-Hartman by mistake
This version fixes that by ensuring the patch is based properly on
GREGKH staging tree, required for upstream acceptance.
---
 drivers/staging/rtl8723bs/core/rtw_cmd.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c b/drivers/staging/rtl8723bs/core/rtw_cmd.c
index 437934dd255e..49bcefb5e8d2 100644
--- a/drivers/staging/rtl8723bs/core/rtw_cmd.c
+++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c
@@ -9,8 +9,8 @@
 #include <linux/jiffies.h>

 static struct _cmd_callback rtw_cmd_callback[] = {
-	{GEN_CMD_CODE(_Read_MACREG), NULL}, /*0*/
-	{GEN_CMD_CODE(_Write_MACREG), NULL},
+	{GEN_CMD_CODE(_read_macreg), NULL}, /*0*/
+	{GEN_CMD_CODE(_write_macreg), NULL},
 	{GEN_CMD_CODE(_Read_BBREG), &rtw_getbbrfreg_cmdrsp_callback},
 	{GEN_CMD_CODE(_Write_BBREG), NULL},
 	{GEN_CMD_CODE(_Read_RFREG), &rtw_getbbrfreg_cmdrsp_callback},
-- 
2.43.0