linux-kernel - RE: [PATCH v2 1/3] dt-bindings: i2c: Add required properties

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <PH7PR12MB81786101346C061EA73472FFC065A@PH7PR12MB8178.namprd12.prod.outlook.com>
Date: Mon, 26 May 2025 05:29:52 +0000
From: Akhil R <akhilrajeev@...dia.com>
To: Jon Hunter <jonathanh@...dia.com>, Krzysztof Kozlowski <krzk@...nel.org>,
	"andi.shyti@...nel.org" <andi.shyti@...nel.org>, "robh@...nel.org"
	<robh@...nel.org>, "krzk+dt@...nel.org" <krzk+dt@...nel.org>,
	"thierry.reding@...il.com" <thierry.reding@...il.com>, Laxman Dewangan
	<ldewangan@...dia.com>, "digetx@...il.com" <digetx@...il.com>,
	"p.zabel@...gutronix.de" <p.zabel@...gutronix.de>,
	"linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v2 1/3] dt-bindings: i2c: Add required properties

> On 16/05/2025 13:53, Krzysztof Kozlowski wrote:
> > On 16/05/2025 14:43, Akhil R wrote:
> >> Add required DT properties for Tegra I2C controllers.
> >
> > Why? Required by whom/what? Some context or any justification is
> > needed here. Are you breaking the ABI (means: prove that you are not).
> >
> > Please use subject prefixes matching the subsystem. You can get them
> > for example with `git log --oneline -- DIRECTORY_OR_FILE` on the
> > directory your patch is touching. For bindings, the preferred subjects
> > are explained here:
> > https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-
> > patches.html#i-for-patch-submitters
> >
> >>
> >> Signed-off-by: Akhil R <akhilrajeev@...dia.com>
> >> ---
> >> v1->v2:
> >>    * Added all required properties
> >>
> >>   .../bindings/i2c/nvidia,tegra20-i2c.yaml      | 19 +++++++++++++++++++
> >>   1 file changed, 19 insertions(+)
> >>
> >> diff --git
> >> a/Documentation/devicetree/bindings/i2c/nvidia,tegra20-i2c.yaml
> >> b/Documentation/devicetree/bindings/i2c/nvidia,tegra20-i2c.yaml
> >> index 19aefc022c8b..0717f2304cfc 100644
> >> --- a/Documentation/devicetree/bindings/i2c/nvidia,tegra20-i2c.yaml
> >> +++ b/Documentation/devicetree/bindings/i2c/nvidia,tegra20-i2c.yaml
> >> @@ -118,6 +118,13 @@ properties:
> >>         - const: rx
> >>         - const: tx
> >>
> >> +required:
> >> +  - compatible
> >> +  - reg
> >> +  - interrupts
> >> +  - clocks
> >> +  - clock-names
> >> +
> >>   allOf:
> >>     - $ref: /schemas/i2c/i2c-controller.yaml
> >>     - if:
> >> @@ -171,6 +178,18 @@ allOf:
> >>         properties:
> >>           power-domains: false
> >>
> >> +  - if:
> >> +      not:
> >> +        properties:
> >> +          compatible:
> >> +            contains:
> >> +              enum:
> >> +                - nvidia,tegra194-i2c
> >> +    then:
> >> +        required:
> >
> > Never tested, so quite dissapointing.
> >
> > Test your patches before sending, not after.
> 
> ACK. Clearly we need to do a better job here. It is noted.

ACK to the comments. Updated the commit description and fixed the indentation
issue and sent out a new version.
https://lore.kernel.org/lkml/20250526052553.42766-1-akhilrajeev@nvidia.com/T/#t

I ran the below tests, did not see any error or warning with the new version.

make dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/i2c/nvidia,tegra20-i2c.yaml
make DT_CHECKER_FLAGS=-m dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/i2c/nvidia,tegra20-i2c.yaml

Regards,
Akhil