linux-kernel - RE: [PATCH] tipc: use kfree_sensitive() for aead cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <AM8P189MB13141C14A4AC551B718CB285C665A@AM8P189MB1314.EURP189.PROD.OUTLOOK.COM>
Date: Mon, 26 May 2025 01:02:48 +0000
From: Tung Quang Nguyen <tung.quang.nguyen@....tech>
To: Zilin Guan <zilin@....edu.cn>
CC: "davem@...emloft.net" <davem@...emloft.net>, "edumazet@...gle.com"
	<edumazet@...gle.com>, "kuba@...nel.org" <kuba@...nel.org>,
	"pabeni@...hat.com" <pabeni@...hat.com>, "horms@...nel.org"
	<horms@...nel.org>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"tipc-discussion@...ts.sourceforge.net"
	<tipc-discussion@...ts.sourceforge.net>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "jianhao.xu@....edu.cn"
	<jianhao.xu@....edu.cn>, "jmaloy@...hat.com" <jmaloy@...hat.com>
Subject: RE: [PATCH] tipc: use kfree_sensitive() for aead cleanup

>Subject: [PATCH] tipc: use kfree_sensitive() for aead cleanup
>
>The tipc_aead_free() function currently uses kfree() to release the aead
>structure. However, this structure contains sensitive information, such as key's
>SALT value, which should be securely erased from memory to prevent potential
>leakage.
>
>To enhance security, replace kfree() with kfree_sensitive() when freeing the
>aead structure. This change ensures that sensitive data is explicitly cleared
>before memory deallocation, aligning with the approach used in
>tipc_aead_init() and adhering to best practices for handling confidential
>information.
>
>Signed-off-by: Zilin Guan <zilin@....edu.cn>
>---
> net/tipc/crypto.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/net/tipc/crypto.c b/net/tipc/crypto.c index
>8584893b4785..f4cfe88670f5 100644
>--- a/net/tipc/crypto.c
>+++ b/net/tipc/crypto.c
>@@ -425,7 +425,7 @@ static void tipc_aead_free(struct rcu_head *rp)
> 	}
> 	free_percpu(aead->tfm_entry);
> 	kfree_sensitive(aead->key);
>-	kfree(aead);
>+	kfree_sensitive(aead);
> }
>
> static int tipc_aead_users(struct tipc_aead __rcu *aead)
>--
>2.34.1
>
Reviewed-by: Tung Nguyen <tung.quang.nguyen@....tech>