linux-kernel - Re: [PATCH] spi: spi-qpic-snand: use NANDC_STEP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d859183f-d9dc-1db4-e6a6-7db1cbdbaab7@quicinc.com>
Date: Mon, 26 May 2025 11:05:39 +0530
From: Md Sadre Alam <quic_mdalam@...cinc.com>
To: Gabor Juhos <j4g8y7@...il.com>, Mark Brown <broonie@...nel.org>
CC: Varadarajan Narayanan <quic_varada@...cinc.com>,
        Sricharan Ramabadhran
	<quic_srichara@...cinc.com>,
        <linux-spi@...r.kernel.org>, <linux-arm-msm@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] spi: spi-qpic-snand: use NANDC_STEP_SIZE consistently

Hi,

On 5/25/2025 7:45 PM, Gabor Juhos wrote:
> Change the qcom_spi_read_page_ecc() function to use NANDC_STEP_SIZE
> instead of a magic number while calculating the data size to keep it
> consistent with other functions like qcom_spi_program_{raw,ecc,oob}
> and qcom_spi_read_cw_{raw,page_oob}.
> 
> No functional changes.
> 
> Signed-off-by: Gabor Juhos <j4g8y7@...il.com>
> ---
>   drivers/spi/spi-qpic-snand.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/spi/spi-qpic-snand.c b/drivers/spi/spi-qpic-snand.c
> index fd129650434f0129e24d3bdac7e7c4d5542627e6..037178d6576e82c3f19c3cc2c6c78f056dc488af 100644
> --- a/drivers/spi/spi-qpic-snand.c
> +++ b/drivers/spi/spi-qpic-snand.c
> @@ -821,7 +821,7 @@ static int qcom_spi_read_page_ecc(struct qcom_nand_controller *snandc,
>   		int data_size, oob_size;
>   
>   		if (i == (num_cw - 1)) {
> -			data_size = 512 - ((num_cw - 1) << 2);
> +			data_size = NANDC_STEP_SIZE - ((num_cw - 1) << 2);
>   			oob_size = (num_cw << 2) + ecc_cfg->ecc_bytes_hw +
>   				    ecc_cfg->spare_bytes;
>   		} else {
> 
> ---
> base-commit: b00d6864a4c948529dc6ddd2df76bf175bf27c63
> change-id: 20250525-qpic-snand-nandc_step_size-5606f4aaeda0
> 
> Best regards,

Reviewed-by: Md Sadre Alam <quic_mdalam@...cinc.com>