linux-kernel - Re: [PATCH 01/23] md: add a new parameter 'offset' to md_super

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a5c43105-a864-910d-94c3-bf815e2fc596@huaweicloud.com>
Date: Mon, 26 May 2025 15:28:44 +0800
From: Yu Kuai <yukuai1@...weicloud.com>
To: Christoph Hellwig <hch@....de>, Yu Kuai <yukuai1@...weicloud.com>
Cc: xni@...hat.com, colyli@...nel.org, song@...nel.org,
 linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-raid@...r.kernel.org, yi.zhang@...wei.com, yangerkun@...wei.com,
 johnny.chenyi@...wei.com, "yukuai (C)" <yukuai3@...wei.com>
Subject: Re: [PATCH 01/23] md: add a new parameter 'offset' to
 md_super_write()

Hi,

在 2025/05/26 14:28, Christoph Hellwig 写道:
> On Sat, May 24, 2025 at 02:12:58PM +0800, Yu Kuai wrote:
>> -void md_super_write(struct mddev *mddev, struct md_rdev *rdev,
>> -		   sector_t sector, int size, struct page *page)
>> +void md_write_metadata(struct mddev *mddev, struct md_rdev *rdev,
>> +		       sector_t sector, int size, struct page *page,
>> +		       unsigned int offset)
> 
> Maybe add a little command explaining what it does?

OK.
> 
>> +extern void md_write_metadata(struct mddev *mddev, struct md_rdev *rdev,
>> +			      sector_t sector, int size, struct page *page,
>> +			      unsigned int offset);
> 
> No need for the extern.  Otherwise looks good:

Got it.
Thanks for the review!

Kuai

> 
> Reviewed-by: Christoph Hellwig <hch@....de>
> 
> .
>