linux-kernel - Re: [PATCH 3/5] MAINTAINERS: Add entry for allegrodvt Gen 3 drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <dujdd63m77qkcey3a54hpykklptdsw6n3njas6uk6brqklekxg@vltajft3fmtu>
Date: Mon, 26 May 2025 07:51:20 +0000
From: Yassine Ouaissa <yassine.ouaissa@...egrodvt.com>
To: Nicolas Dufresne <nicolas@...fresne.ca>
Cc: Mauro Carvalho Chehab <mchehab@...nel.org>, 
	Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, 
	Conor Dooley <conor+dt@...nel.org>, Michael Tretter <m.tretter@...gutronix.de>, 
	Pengutronix Kernel Team <kernel@...gutronix.de>, Michal Simek <michal.simek@....com>, 
	Neil Armstrong <neil.armstrong@...aro.org>, Heiko Stuebner <heiko@...ech.de>, 
	Junhao Xie <bigfoot@...ssfun.cn>, Rafa?? Mi??ecki <rafal@...ecki.pl>, 
	Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>, Kever Yang <kever.yang@...k-chips.com>, 
	Hans Verkuil <hverkuil@...all.nl>, Joe Hattori <joe@...is.s.u-tokyo.ac.jp>, 
	Uwe Kleine-K??nig <u.kleine-koenig@...libre.com>, Gaosheng Cui <cuigaosheng1@...wei.com>, 
	Christophe JAILLET <christophe.jaillet@...adoo.fr>, Wolfram Sang <wsa+renesas@...g-engineering.com>, 
	Ricardo Ribalda <ribalda@...omium.org>, linux-media@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 3/5] MAINTAINERS: Add entry for allegrodvt Gen 3 drivers

On 25.05.2025 17:50, Nicolas Dufresne wrote:
>Hi Yassine,
>
>Le vendredi 23 mai 2025 à 15:41 +0200, Yassine Ouaissa a écrit :
>> Add my self as maintainer of the allegrodvt Gen drivers
>>
>> Signed-off-by: Yassine Ouaissa <yassine.ouaissa@...egrodvt.com>
>> ---
>>  MAINTAINERS | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index e59011a36e6b..9285bb2f43d9 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -802,6 +802,7 @@ F:	drivers/platform/x86/dell/alienware-wmi*
>>  
>>  ALLEGRO DVT VIDEO IP CORE DRIVER
>>  M:	Michael Tretter <m.tretter@...gutronix.de>
>> +M:	Yassine OUAISSA <yassine.ouaissa@...egrodvt.com>
>>  R:	Pengutronix Kernel Team <kernel@...gutronix.de>
>>  L:	linux-media@...r.kernel.org
>>  S:	Maintained
>
>Be aware that I do not endorse Krzysztof style of communication, and this
>does not reflect Linux Media values. We strongly encourage both new comers and
>contributions coming from the hardware companies. Please, don't get discourage,
>simply focus on the facts and the way forward. DT maintainers don't usually deal
>with pre-silicon drivers, so we'll have to see what this means for
>bindings. But having drivers contributed before the hardware is a clear win
>for the Linux kernel, so we should all encourage this and find a way.

Hi Nicolas,

Thank you for your support.
I already informe Krzysztof by email, that i have not make a good
approach with the previous patches, and i will send a new set of patches
to start cleanly.

And also i informed the linux-media community, and they was "OK" with
that.
>
>In general, don't assume any of the above is known and document it. Its quite possible
>your reviewers so far have been thinking this driver is for existing hardware already
>running in a known SoC. They cannot guess, you have to make things really clear and
>transparent.
>
>Meanwhile, a better approach to maintenance, and the one I expected initially, is to
>place yourself under Michael in the hierarchy, and remove yourself from the bindings
>path. Bindings should really come from the SoC vendor in practice, so perhaps we should
>not provide a generic one. Hopefully we can get proper feedback from DT maintainers on
>that aspect.

right, the al300-vdec dt-bindings is a generic one that the soc vendors
should follow for the specific driver.

>
>I'd like to see a focus move onto the driver code, which is at this stage much more
>important. In parallel, spend time to re-read the guidelines for submissions and
>check some automation tools. 'b4' is really my goto, and will help you avoid some
>of the common mistakes.

thank you for the tool, and also for the review.
>
>regards,
>Nicolas
>
>
>
Best regards,
Yassine OUAISSA