linux-kernel - Re: [PATCH] net: macb: Check return value of dma_set_mask_and

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8e1250b2-b6da-4294-b02b-98c9d231a181@tuxon.dev>
Date: Mon, 26 May 2025 11:04:20 +0300
From: Claudiu Beznea <claudiu.beznea@...on.dev>
To: Sergio Perez Gonzalez <sperezglz@...il.com>, nicolas.ferre@...rochip.com
Cc: andrew+netdev@...n.ch, davem@...emloft.net, edumazet@...gle.com,
 kuba@...nel.org, pabeni@...hat.com, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org, shuah@...nel.org
Subject: Re: [PATCH] net: macb: Check return value of
 dma_set_mask_and_coherent()



On 26.05.2025 06:20, Sergio Perez Gonzalez wrote:
> Issue flagged by coverity. Add a safety check for the return value
> of dma_set_mask_and_coherent, go to a safe exit if it returns error.
> 
> Link: https://scan7.scan.coverity.com/#/project-view/53936/11354?selectedIssue=1643754
> 
> Signed-off-by: Sergio Perez Gonzalez <sperezglz@...il.com>

Reviewed-by: Claudiu Beznea <claudiu.beznea@...on.dev>

> ---
>  drivers/net/ethernet/cadence/macb_main.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c
> index e1e8bd2ec155..d1f1ae5ea161 100644
> --- a/drivers/net/ethernet/cadence/macb_main.c
> +++ b/drivers/net/ethernet/cadence/macb_main.c
> @@ -5283,7 +5283,11 @@ static int macb_probe(struct platform_device *pdev)
>  
>  #ifdef CONFIG_ARCH_DMA_ADDR_T_64BIT
>  	if (GEM_BFEXT(DAW64, gem_readl(bp, DCFG6))) {
> -		dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(44));
> +		err = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(44));
> +		if (err) {
> +			dev_err(&pdev->dev, "failed to set DMA mask\n");
> +			goto err_out_free_netdev;
> +		}
>  		bp->hw_dma_cap |= HW_DMA_CAP_64B;
>  	}
>  #endif