linux-kernel - Re: [PATCH 2/3] rust: pin-init: examples: pthread

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <DA5Y29IWBB91.HTQ1WI3824FX@kernel.org>
Date: Mon, 26 May 2025 10:20:29 +0200
From: "Benno Lossin" <lossin@...nel.org>
To: "Alice Ryhl" <aliceryhl@...gle.com>
Cc: "Miguel Ojeda" <ojeda@...nel.org>, "Alex Gaynor"
 <alex.gaynor@...il.com>, "Boqun Feng" <boqun.feng@...il.com>, "Gary Guo"
 <gary@...yguo.net>, Björn Roy Baron
 <bjorn3_gh@...tonmail.com>, "Andreas Hindborg" <a.hindborg@...nel.org>,
 "Trevor Gross" <tmgross@...ch.edu>, "Danilo Krummrich" <dakr@...nel.org>,
 "Fiona Behrens" <me@...enk.dev>, "Benno Lossin" <benno.lossin@...ton.me>,
 <rust-for-linux@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/3] rust: pin-init: examples: pthread_mutex: disable
 the main test for miri

On Fri May 23, 2025 at 8:26 PM CEST, Alice Ryhl wrote:
> On Fri, May 23, 2025 at 02:54:12PM +0200, Benno Lossin wrote:
>> From: Benno Lossin <benno.lossin@...ton.me>
>> 
>> `miri` takes a long time to execute the test, so disable it.
>> 
>> Link: https://github.com/Rust-for-Linux/pin-init/pull/50/commits/e717a9eec85024c11e79e8bd9dcb664ad0de8f94
>> Signed-off-by: Benno Lossin <lossin@...nel.org>
>
> I usually recommend ignoring tests rather than cfg'ing them out
> entirely.
>
> #[cfg_attr(miri, ignore)]

Oh I didn't know you can do that!

This patch sadly already is in the main branch and I have the policy
that I don't rebase that one, so I'll make another patch to fix that.
(and in the future I'll wait with merging for reviews on the list :)

---
Cheers,
Benno