linux-kernel - Re: [PATCH 5/7] phy: phy-snps-eusb2: fix optional phy lookup parameter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6de7286f-802a-4de2-9030-6937e85a5aee@linaro.org>
Date: Mon, 26 May 2025 10:27:48 +0200
From: neil.armstrong@...aro.org
To: Johan Hovold <johan+linaro@...nel.org>, Vinod Koul <vkoul@...nel.org>
Cc: Kishon Vijay Abraham I <kishon@...nel.org>,
 Ivaylo Ivanov <ivo.ivanov.ivanov1@...il.com>,
 Abel Vesa <abel.vesa@...aro.org>, linux-phy@...ts.infradead.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH 5/7] phy: phy-snps-eusb2: fix optional phy lookup
 parameter

On 23/05/2025 10:48, Johan Hovold wrote:
> The devm_of_phy_optional_get() takes an optional name argument as its
> third parameter and not an index like the recently replaced
> devm_of_phy_get_by_index().
> 
> Replace 0 with an explicit NULL for consistency and readability.
> 
> Signed-off-by: Johan Hovold <johan+linaro@...nel.org>
> ---
>   drivers/phy/phy-snps-eusb2.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/phy/phy-snps-eusb2.c b/drivers/phy/phy-snps-eusb2.c
> index 232c5e8a554f..328e67ebfe03 100644
> --- a/drivers/phy/phy-snps-eusb2.c
> +++ b/drivers/phy/phy-snps-eusb2.c
> @@ -581,7 +581,7 @@ static int snps_eusb2_hsphy_probe(struct platform_device *pdev)
>   		return dev_err_probe(dev, ret,
>   				     "failed to get regulator supplies\n");
>   
> -	phy->repeater = devm_of_phy_optional_get(dev, np, 0);
> +	phy->repeater = devm_of_phy_optional_get(dev, np, NULL);
>   	if (IS_ERR(phy->repeater))
>   		return dev_err_probe(dev, PTR_ERR(phy->repeater),
>   				     "failed to get repeater\n");

Reviewed-by: Neil Armstrong <neil.armstrong@...aro.org>