linux-kernel - Re: [PATCH v2 2/2] drm: add overview diagram for drm stack

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aDPJNBTDmHoZ-z1d@archie.me>
Date: Mon, 26 May 2025 08:51:48 +0700
From: Bagas Sanjaya <bagasdotme@...il.com>
To: Abdulrasaq Lawani <abdulrasaqolawani@...il.com>,
	Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
	Maxime Ripard <mripard@...nel.org>,
	Thomas Zimmermann <tzimmermann@...e.de>,
	David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
	Jonathan Corbet <corbet@....net>
Cc: dri-devel@...ts.freedesktop.org, linux-doc@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/2] drm: add overview diagram for drm stack

On Fri, May 23, 2025 at 03:52:26PM -0400, Abdulrasaq Lawani wrote:
> diff --git a/Documentation/gpu/introduction.rst b/Documentation/gpu/introduction.rst
> index 91bb0efc96d69921a122c5265b1431fa18110a7a..2653048ad4bb0ecbc2b676295440442dddbabae6 100644
> --- a/Documentation/gpu/introduction.rst
> +++ b/Documentation/gpu/introduction.rst
> @@ -15,41 +15,43 @@ and the new vblank internals, in addition to all the regular features
>  found in current kernels.
>  
>  Overview of the Linux DRM Architecture
> ------------------------------------------------
> -+-----------------------------+
> -|     User-space Apps         |
> -| (Games, Browsers, ML, etc.) |
> -+-----------------------------+
> -              |
> -              v
> -+---------------------------------------+
> -|    Graphics APIs   |   Compute APIs   |
> -|  (OpenGL, Vulkan)  |  (OpenCL, CUDA)  |
> -+---------------------------------------+
> -          |                   |
> -          v                   v
> -+---------------------+  +-----------------------+
> -|  User-space Driver  |  |    Compute Runtime    |
> -|  (Mesa, AMD/NVIDIA) |  |  (OpenCL, CUDA, ROCm) |
> -+---------------------+  +-----------------------+
> -          |                   |
> -          +--------+----------+
> -                   |
> -                   v
> -        +-----------------------+
> -        |   libdrm (DRM API)    |
> -        +-----------------------+
> -                   |
> -                   v
> -+-------------------------------------------+
> -|     Kernel DRM/KMS Driver (i915, amdgpu,  |
> -|     nouveau, etc.)                        |
> -+-------------------------------------------+
> -        |                       |
> -        v                       v
> -+----------------+     +-------------------+
> -| GPU Display HW |     | GPU Compute Units |
> -+----------------+     +-------------------+
> +======================================

Why promoting the section heading?

> +::
> +
> +        +-----------------------------+
> +        |     User-space Apps         |
> +        | (Games, Browsers, ML, etc.) |
> +        +-----------------------------+
> +                      |
> +                      v
> +        +---------------------------------------+
> +        |    Graphics APIs   |   Compute APIs   |
> +        |  (OpenGL, Vulkan)  |  (OpenCL, CUDA)  |
> +        +---------------------------------------+
> +                |                   |
> +                v                   v
> +        +---------------------+  +-----------------------+
> +        |  User-space Driver  |  |    Compute Runtime    |
> +        |  (Mesa, AMD/NVIDIA) |  |  (OpenCL, CUDA, ROCm) |
> +        +---------------------+  +-----------------------+
> +                |                   |
> +                +--------+----------+
> +                         |
> +                         v
> +                +-----------------------+
> +                |   libdrm (DRM API)    |
> +                +-----------------------+
> +                          |
> +                          v
> +        +-------------------------------------------+
> +        |     Kernel DRM/KMS Driver (i915, amdgpu,  |
> +        |     nouveau, etc.)                        |
> +        +-------------------------------------------+
> +                |                       |
> +                v                       v
> +        +----------------+     +-------------------+
> +        | GPU Display HW |     | GPU Compute Units |
> +        +----------------+     +-------------------+
>  

This is not how reviews from v1 should be addressed. Instead of making
separate commit for review suggestions, you need to squash them into affected
commit(s) in v1. In this case, there should be only one resulting patch. Don't
forget to send it as v3.

Thanks.

-- 
An old man doll... just what I always wanted! - Clara

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)