linux-kernel - Re: [PATCH 2/2] media: uapi: Document IOCTL number assignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250526114824.GE17743@pendragon.ideasonboard.com>
Date: Mon, 26 May 2025 13:48:24 +0200
From: Laurent Pinchart <laurent.pinchart@...asonboard.com>
To: Sakari Ailus <sakari.ailus@...ux.intel.com>
Cc: linux-doc@...r.kernel.org, Jonathan Corbet <corbet@....net>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Madhavan Srinivasan <maddy@...ux.ibm.com>,
	Haren Myneni <haren@...ux.ibm.com>,
	Bagas Sanjaya <bagasdotme@...il.com>,
	Andrew Donnellan <ajd@...ux.ibm.com>,
	Michael Ellerman <mpe@...erman.id.au>,
	Akshay Gupta <akshay.gupta@....com>, linux-kernel@...r.kernel.org,
	linux-media@...r.kernel.org, hans@...erkuil.nl,
	Mauro Carvalho Chehab <mchehab+huawei@...nel.org>,
	Lee Jones <lee@...nel.org>
Subject: Re: [PATCH 2/2] media: uapi: Document IOCTL number assignment

Hi Sakari,

Thank you for the patch.


On Mon, May 26, 2025 at 02:17:32PM +0300, Sakari Ailus wrote:
> Document MC IOCTL number assignment in linux/media.h. In the past the
> assignment up to 0x7f was missed so to prevent that from happening again,
> document the value here as well.
> 
> Signed-off-by: Sakari Ailus <sakari.ailus@...ux.intel.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>

> ---
>  include/uapi/linux/media.h | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/include/uapi/linux/media.h b/include/uapi/linux/media.h
> index 1c80b1d6bbaf..2808132fcf49 100644
> --- a/include/uapi/linux/media.h
> +++ b/include/uapi/linux/media.h
> @@ -381,6 +381,10 @@ struct media_v2_topology {
>   */
>  #define MEDIA_REQUEST_IOC_QUEUE		_IO('|',  0x80)
>  #define MEDIA_REQUEST_IOC_REINIT	_IO('|',  0x81)
> +/*
> + * Don't allocate new IOCTL numbers past 0x8f, MC IOCTL number assignment ends
> + * there!
> + */
>  
>  #ifndef __KERNEL__
>  

-- 
Regards,

Laurent Pinchart