[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <31c8c819-6814-499c-8d55-d22d4939c851@infradead.org>
Date: Sun, 25 May 2025 19:28:41 -0700
From: Randy Dunlap <rdunlap@...radead.org>
To: Arnd Bergmann <arnd@...nel.org>, MyungJoo Ham <myungjoo.ham@...sung.com>,
Chanwoo Choi <cw00.choi@...sung.com>, Svyatoslav Ryhel <clamor95@...il.com>
Cc: Arnd Bergmann <arnd@...db.de>, Hans de Goede <hdegoede@...hat.com>,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] extcon: max14526: add CONFIG_I2C dependency
On 5/20/25 8:26 AM, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
>
> When I2C is in a loadable module, the newly added driver causes
> a build failure. The problem is shown by Kconfig:
>
> WARNING: unmet direct dependencies detected for REGMAP_I2C
> Depends on [m]: I2C [=m]
> Selected by [y]:
> - EXTCON_MAX14526 [=y] && EXTCON [=y]
>
> Add the required dependency here.
Same as my patch:
https://lore.kernel.org/lkml/20250515234803.1385375-1-rdunlap@infradead.org/
>
> Fixes: c2aeb8647e53 ("extcon: Add basic support for Maxim MAX14526 MUIC")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
> drivers/extcon/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/extcon/Kconfig b/drivers/extcon/Kconfig
> index 1096afc0b5bb..aec46bf03302 100644
> --- a/drivers/extcon/Kconfig
> +++ b/drivers/extcon/Kconfig
> @@ -136,6 +136,7 @@ config EXTCON_MAX8997
>
> config EXTCON_MAX14526
> tristate "Maxim MAX14526 EXTCON Support"
> + depends on I2C
> select IRQ_DOMAIN
> select REGMAP_I2C
> help
Powered by blists - more mailing lists