linux-kernel - Re: [PATCH 04/45] drm/msm/dp: split msm_dp_panel_read_sink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6367013c-58c9-478e-8399-b4a53e2d8a66@quicinc.com>
Date: Mon, 26 May 2025 20:21:40 +0800
From: Yongxing Mou <quic_yongmou@...cinc.com>
To: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
CC: Abhinav Kumar <quic_abhinavk@...cinc.com>,
        Rob Clark
	<robdclark@...il.com>, Sean Paul <sean@...rly.run>,
        Marijn Suijten
	<marijn.suijten@...ainline.org>,
        David Airlie <airlied@...il.com>, "Simona
 Vetter" <simona@...ll.ch>,
        Stephen Boyd <swboyd@...omium.org>,
        "Chandan
 Uddaraju" <chandanu@...eaurora.org>,
        Guenter Roeck <groeck@...omium.org>,
        Kuogee Hsieh <quic_khsieh@...cinc.com>,
        Bjorn Andersson
	<andersson@...nel.org>,
        Konrad Dybcio <konradybcio@...nel.org>, Rob Herring
	<robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley
	<conor+dt@...nel.org>,
        Vara Reddy <quic_varar@...cinc.com>,
        Rob Clark
	<robdclark@...omium.org>,
        Tanmay Shah <tanmay@...eaurora.org>, <linux-arm-msm@...r.kernel.org>,
        <dri-devel@...ts.freedesktop.org>, <freedreno@...ts.freedesktop.org>,
        <linux-kernel@...r.kernel.org>, <devicetree@...r.kernel.org>,
        Jessica Zhang <quic_jesszhan@...cinc.com>,
        Laurent Pinchart <laurent.pinchart@...asonboard.com>
Subject: Re: [PATCH 04/45] drm/msm/dp: split msm_dp_panel_read_sink_caps()
 into two parts



On 2025/5/22 20:38, Dmitry Baryshkov wrote:
> On Thu, May 22, 2025 at 05:51:52PM +0800, Yongxing Mou wrote:
>>
>>
>> On 2024/12/6 16:51, Dmitry Baryshkov wrote:
>>> On Thu, Dec 05, 2024 at 08:31:35PM -0800, Abhinav Kumar wrote:
>>>> In preparation of DP MST where link caps are read for the
>>>> immediate downstream device and the edid is read through
>>>> sideband messaging, split the msm_dp_panel_read_sink_caps() into
>>>> two parts which read the link parameters and the edid parts
>>>> respectively.
>>>
>>> As you are touching this part, could you please refactor the code
>>> instead by dropping the msm_dp_panel->drm_edid? There should be no need
>>> to store EDID in the panel structure.
>>>
>> Hi, Dmitry, Abhinav will be leaving the company and will no longer be
>> responsible for updating and address the comments. I will take over handling
>> MST patch series. Regarding this comments, I don't got that where the
>> drm_edid should be stored. In MST cases, where multiple panels exist, i
>> think that there should be a separate drm_edid saved for each panel.
> 
> Why do we need to store EDID at all?
> 
Got it. Will try to drop it.