linux-kernel - Re: [PATCH v4 05/23] iommufd/driver: Let iommufd_viommu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250526133046.GD9786@nvidia.com>
Date: Mon, 26 May 2025 10:30:46 -0300
From: Jason Gunthorpe <jgg@...dia.com>
To: Nicolin Chen <nicolinc@...dia.com>
Cc: kevin.tian@...el.com, corbet@....net, will@...nel.org,
	bagasdotme@...il.com, robin.murphy@....com, joro@...tes.org,
	thierry.reding@...il.com, vdumpa@...dia.com, jonathanh@...dia.com,
	shuah@...nel.org, jsnitsel@...hat.com, nathan@...nel.org,
	peterz@...radead.org, yi.l.liu@...el.com, mshavit@...gle.com,
	praan@...gle.com, zhangzekun11@...wei.com, iommu@...ts.linux.dev,
	linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, linux-tegra@...r.kernel.org,
	linux-kselftest@...r.kernel.org, patches@...ts.linux.dev,
	mochs@...dia.com, alok.a.tiwari@...cle.com, vasant.hegde@....com
Subject: Re: [PATCH v4 05/23] iommufd/driver: Let iommufd_viommu_alloc helper
 save ictx to viommu->ictx

On Fri, May 16, 2025 at 01:56:26PM -0700, Nicolin Chen wrote:

> > You don't need to move this unless you are using inlines. Just use a
> > forward declaration.
> 
> Since we forward ucmd now, ictx is in the ucmd so we need this
> structure for:
> 
> -		if (!IS_ERR(ret))                                              \
> +		if (!IS_ERR(ret)) {                                            \
>  			ret->member.ops = viommu_ops;                          \
> +			ret->member.ictx = ucmd->ictx;                         \
> +		}                                                              \

De-inline more of that function probably..

Also seem my other remarks about not storing ictx so much..

Jason