linux-kernel - Re: [RFC PATCH v6 07/32] KVM: x86: apic_test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4dd45ddb-5faf-4766-b829-d7e10d3d805f@amd.com>
Date: Mon, 26 May 2025 08:30:14 +0530
From: Neeraj Upadhyay <Neeraj.Upadhyay@....com>
To: Borislav Petkov <bp@...en8.de>
Cc: linux-kernel@...r.kernel.org, tglx@...utronix.de, mingo@...hat.com,
 dave.hansen@...ux.intel.com, Thomas.Lendacky@....com, nikunj@....com,
 Santosh.Shukla@....com, Vasant.Hegde@....com, Suravee.Suthikulpanit@....com,
 David.Kaplan@....com, x86@...nel.org, hpa@...or.com, peterz@...radead.org,
 seanjc@...gle.com, pbonzini@...hat.com, kvm@...r.kernel.org,
 kirill.shutemov@...ux.intel.com, huibo.wang@....com, naveen.rao@....com,
 francescolavra.fl@...il.com, tiala@...rosoft.com
Subject: Re: [RFC PATCH v6 07/32] KVM: x86: apic_test_vector() to common code

On 5/24/2025 5:42 PM, Borislav Petkov wrote: 
> 
> The previous patch is moving those *_POS() macros to arch/x86/kvm/lapic.c, now
> this patch is doing rename-during-move to the new macros.
> 
> Why can't you simply do the purely mechanical moves first and then do the
> renames? Didn't I explain it the last time? Or is it still unclear?
> 

I thought it was clear to me when you explained last time. However, I did this
rename-during-move because of below reason. Please correct me if I am wrong here.

VEC_POS, REG_POS are kvm-internal wrappers for APIC_VECTOR_TO_BIT_NUMBER/
APIC_VECTOR_TO_REG_OFFSET macros which got defined in patch 01/32. Prior to patch
06/32, these macros were defined in kvm-internal header arch/x86/kvm/lapic.h. Using
VEC_POS, REG_POS kvm-internal macros in x86 common header file (arch/x86/include/asm/apic.h)
in this patch did not look correct to me and as APIC_VECTOR_TO_BIT_NUMBER/APIC_VECTOR_TO_REG_OFFSET
are already defined in arch/x86/include/asm/apic.h, I used them.

Is adding this information in commit log of this patch sufficient or do you have some
other suggestion for doing this?

- Neeraj