[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <DA66OFXQCWUK.31LM78DIVABZV@kernel.org>
Date: Mon, 26 May 2025 17:05:36 +0200
From: "Benno Lossin" <lossin@...nel.org>
To: "Tamir Duberstein" <tamird@...il.com>, "Michal Rostecki"
<vadorovsky@...tonmail.com>, "Miguel Ojeda" <ojeda@...nel.org>, "Alex
Gaynor" <alex.gaynor@...il.com>, "Boqun Feng" <boqun.feng@...il.com>, "Gary
Guo" <gary@...yguo.net>, Björn Roy Baron
<bjorn3_gh@...tonmail.com>, "Andreas Hindborg" <a.hindborg@...nel.org>,
"Alice Ryhl" <aliceryhl@...gle.com>, "Trevor Gross" <tmgross@...ch.edu>,
"Brendan Higgins" <brendan.higgins@...ux.dev>, "David Gow"
<davidgow@...gle.com>, "Rae Moar" <rmoar@...gle.com>, "Danilo Krummrich"
<dakr@...nel.org>, "Maarten Lankhorst" <maarten.lankhorst@...ux.intel.com>,
"Maxime Ripard" <mripard@...nel.org>, "Thomas Zimmermann"
<tzimmermann@...e.de>, "David Airlie" <airlied@...il.com>, "Simona Vetter"
<simona@...ll.ch>, "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>,
"Rafael J. Wysocki" <rafael@...nel.org>, "Luis Chamberlain"
<mcgrof@...nel.org>, "Russ Weight" <russ.weight@...ux.dev>, "FUJITA
Tomonori" <fujita.tomonori@...il.com>, "Rob Herring" <robh@...nel.org>,
"Saravana Kannan" <saravanak@...gle.com>, "Peter Zijlstra"
<peterz@...radead.org>, "Ingo Molnar" <mingo@...hat.com>, "Will Deacon"
<will@...nel.org>, "Waiman Long" <longman@...hat.com>, "Nathan Chancellor"
<nathan@...nel.org>, "Nick Desaulniers" <nick.desaulniers+lkml@...il.com>,
"Bill Wendling" <morbo@...gle.com>, "Justin Stitt"
<justinstitt@...gle.com>, "Andrew Lunn" <andrew@...n.ch>, "Heiner Kallweit"
<hkallweit1@...il.com>, "Russell King" <linux@...linux.org.uk>, "David S.
Miller" <davem@...emloft.net>, "Eric Dumazet" <edumazet@...gle.com>, "Jakub
Kicinski" <kuba@...nel.org>, "Paolo Abeni" <pabeni@...hat.com>, "Bjorn
Helgaas" <bhelgaas@...gle.com>, "Arnd Bergmann" <arnd@...db.de>, "Jens
Axboe" <axboe@...nel.dk>, Krzysztof Wilczyński
<kwilczynski@...nel.org>
Cc: <rust-for-linux@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
<linux-kselftest@...r.kernel.org>, <kunit-dev@...glegroups.com>,
<dri-devel@...ts.freedesktop.org>, <netdev@...r.kernel.org>,
<devicetree@...r.kernel.org>, <llvm@...ts.linux.dev>,
<linux-pci@...r.kernel.org>, <nouveau@...ts.freedesktop.org>,
<linux-block@...r.kernel.org>
Subject: Re: [PATCH v10 5/5] rust: remove core::ffi::CStr reexport
On Sat May 24, 2025 at 10:33 PM CEST, Tamir Duberstein wrote:
> Clean up references to `kernel::str::CStr`.
>
> Signed-off-by: Tamir Duberstein <tamird@...il.com>
> ---
> drivers/gpu/drm/drm_panic_qr.rs | 3 ++-
> drivers/gpu/nova-core/firmware.rs | 2 +-
> drivers/net/phy/ax88796b_rust.rs | 1 +
> drivers/net/phy/qt2025.rs | 1 +
> rust/kernel/device.rs | 3 +--
> rust/kernel/driver.rs | 4 ++--
> rust/kernel/error.rs | 6 ++----
> rust/kernel/faux.rs | 5 ++++-
> rust/kernel/firmware.rs | 15 ++++-----------
> rust/kernel/kunit.rs | 6 +++---
> rust/kernel/lib.rs | 2 +-
> rust/kernel/miscdevice.rs | 3 +--
> rust/kernel/net/phy.rs | 4 +++-
> rust/kernel/of.rs | 3 ++-
> rust/kernel/pci.rs | 2 +-
> rust/kernel/platform.rs | 2 +-
> rust/kernel/prelude.rs | 5 +----
> rust/kernel/str.rs | 22 ++++++++++------------
> rust/kernel/sync/condvar.rs | 4 ++--
> rust/kernel/sync/lock.rs | 4 ++--
> rust/kernel/sync/lock/global.rs | 5 +++--
> rust/kernel/sync/poll.rs | 1 +
> rust/kernel/workqueue.rs | 1 +
> rust/macros/module.rs | 2 +-
> 24 files changed, 51 insertions(+), 55 deletions(-)
Haven't compile tested this series yet, but this commit seems to suggest
to me that some of the previous commits introduced code that doesn't
compile or emits warnings? If so that needs to be fixed.
---
Cheers,
Benno
Powered by blists - more mailing lists