linux-kernel - Re: [PATCH 1/1] dt-bindings: dma: fsl-mxs-dma: allow interrupt-names for fsl,imx23-dma-apbx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250526-plural-nifty-b43938d9f180@spud>
Date: Mon, 26 May 2025 16:28:07 +0100
From: Conor Dooley <conor@...nel.org>
To: Frank Li <Frank.Li@....com>
Cc: Vinod Koul <vkoul@...nel.org>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, Shawn Guo <shawnguo@...nel.org>,
	Sascha Hauer <s.hauer@...gutronix.de>,
	Pengutronix Kernel Team <kernel@...gutronix.de>,
	Fabio Estevam <festevam@...il.com>, Marek Vasut <marex@...x.de>,
	"open list:DMA GENERIC OFFLOAD ENGINE SUBSYSTEM" <dmaengine@...r.kernel.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@...r.kernel.org>,
	"open list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" <imx@...ts.linux.dev>,
	"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" <linux-arm-kernel@...ts.infradead.org>,
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/1] dt-bindings: dma: fsl-mxs-dma: allow interrupt-names
 for fsl,imx23-dma-apbx

On Fri, May 23, 2025 at 05:32:52PM -0400, Frank Li wrote:
> Allow interrupt-names for fsl,imx23-dma-apbx and keep the same restriction
> for others.

The content of the patch seems okay, but why are you doing this? What is
the value on this particular platform but not the others?

> 
> Signed-off-by: Frank Li <Frank.Li@....com>
> ---
>  .../devicetree/bindings/dma/fsl,mxs-dma.yaml  | 33 +++++++++++++++++++
>  1 file changed, 33 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/dma/fsl,mxs-dma.yaml b/Documentation/devicetree/bindings/dma/fsl,mxs-dma.yaml
> index 75a7d9556699c..9102b615dbd61 100644
> --- a/Documentation/devicetree/bindings/dma/fsl,mxs-dma.yaml
> +++ b/Documentation/devicetree/bindings/dma/fsl,mxs-dma.yaml
> @@ -23,6 +23,35 @@ allOf:
>        properties:
>          power-domains: false
>  
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            const: fsl,imx23-dma-apbx
> +    then:
> +      properties:
> +        interrupt-names:
> +          items:
> +            - const: audio-adc
> +            - const: audio-dac
> +            - const: spdif-tx
> +            - const: i2c
> +            - const: saif0
> +            - const: empty0
> +            - const: auart0-rx
> +            - const: auart0-tx
> +            - const: auart1-rx
> +            - const: auart1-tx
> +            - const: saif1
> +            - const: empty1
> +            - const: empty2
> +            - const: empty3
> +            - const: empty4
> +            - const: empty5
> +    else:
> +      properties:
> +        interrupt-names: false
> +
>  properties:
>    compatible:
>      oneOf:
> @@ -54,6 +83,10 @@ properties:
>      minItems: 4
>      maxItems: 16
>  
> +  interrupt-names:
> +    minItems: 4
> +    maxItems: 16
> +
>    "#dma-cells":
>      const: 1
>  
> -- 
> 2.34.1
> 

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)