[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20250526-corset-villain-8b72aefeba75@spud>
Date: Mon, 26 May 2025 16:33:28 +0100
From: Conor Dooley <conor@...nel.org>
To: Frank Li <Frank.Li@....com>
Cc: Christophe Leroy <christophe.leroy@...roup.eu>,
Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>, Shawn Guo <shawnguo@...nel.org>,
Sascha Hauer <s.hauer@...gutronix.de>,
Pengutronix Kernel Team <kernel@...gutronix.de>,
Fabio Estevam <festevam@...il.com>,
"open list:FREESCALE SOC DRIVERS" <linuxppc-dev@...ts.ozlabs.org>,
"moderated list:FREESCALE SOC DRIVERS" <linux-arm-kernel@...ts.infradead.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@...r.kernel.org>,
"open list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" <imx@...ts.linux.dev>,
open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/1] dt-bindings: soc: Add fsl,imx23-digctl.yaml for
i.MX23 and i.MX28
On Fri, May 23, 2025 at 04:45:23PM -0400, Frank Li wrote:
> Add fsl,imx23-digctl.yaml for i.MX23 and i.MX28 to fix below CHECK_DTB
> warning:
>
> arch/arm/boot/dts/nxp/mxs/imx23-sansa.dtb: /apb@...00000/apbh-bus@...00000/digctl@...1c000:
> failed to match any schema with compatible: ['fsl,imx23-digctl']
>
> Signed-off-by: Frank Li <Frank.Li@....com>
> ---
> .../bindings/soc/fsl/fsl,imx23-digctl.yaml | 41 +++++++++++++++++++
> 1 file changed, 41 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/soc/fsl/fsl,imx23-digctl.yaml
>
> diff --git a/Documentation/devicetree/bindings/soc/fsl/fsl,imx23-digctl.yaml b/Documentation/devicetree/bindings/soc/fsl/fsl,imx23-digctl.yaml
> new file mode 100644
> index 0000000000000..47f92f763bfa3
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/soc/fsl/fsl,imx23-digctl.yaml
> @@ -0,0 +1,41 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas//soc/fsl/fsl,imx23-digctl.yaml#
^^ I assume it makes no difference,
but you got a double / here.
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Freescale mxs digctrl for i.MX23/i.MX28
I have no idea reading this what a "digctrl" is. I think you should add
a description briefly mentioning what it does.
> +
> +maintainers:
> + - Frank Li <Frank.Li@....com>
> +
> +properties:
> + compatible:
> + oneOf:
> + - items:
> + - enum:
> + - fsl,imx28-digctl
> + - const: fsl,imx23-digctl
> + - const: fsl,imx23-digctl
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + digctl@...1c000 {
> + compatible = "fsl,imx28-digctl", "fsl,imx23-digctl";
> + reg = <0x8001c000 0x2000>;
> + interrupts = <89>;
> + };
> +
> --
> 2.34.1
>
Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)
Powered by blists - more mailing lists