linux-kernel - Re: [PATCH RFC 1/9] iio: buffer: Fix checkpatch.pl warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250526181508.6203c21a@jic23-huawei>
Date: Mon, 26 May 2025 18:15:08 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: Gyeyoung Baek <gye976@...il.com>
Cc: David Lechner <dlechner@...libre.com>, Nuno Sá
 <nuno.sa@...log.com>, Andy Shevchenko <andy@...nel.org>,
 linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH RFC 1/9] iio: buffer: Fix checkpatch.pl warning

On Mon, 26 May 2025 14:30:41 +0900
Gyeyoung Baek <gye976@...il.com> wrote:

> On Mon, May 26, 2025 at 2:35 AM Jonathan Cameron <jic23@...nel.org> wrote:
> >
> > On Mon, 19 May 2025 23:25:53 +0900
> > Gyeyoung Baek <gye976@...il.com> wrote:
> >  
> > > Remove the following trivial warning:
> > > "WARNING: Block comments should align the * on each line"
> > >
> > > Signed-off-by: Gyeyoung Baek <gye976@...il.com>  
> > Applied.
> >
> > As a general rule don't send unrelated cleanup in an RFC series
> > doing something interesting!  They might get missed.  
> 
> Well, since the patches modify the same file, I considered them
> dependent and grouped them into a single series. But now realize it
> would be more appropriate to split patches logically.
> Thanks for pointing it out.
If there was a chance of a merge conflict I'd agree with you
but I'd be very surprised to see one with this change given where
it is in the file.

No problem though, the only result of too much grouping is
things might not go in as quickly!

Jonathan

> 
> Gyeyoung
> 
> > Jonathan  
> > > ---
> > >  drivers/iio/buffer/industrialio-triggered-buffer.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/iio/buffer/industrialio-triggered-buffer.c b/drivers/iio/buffer/industrialio-triggered-buffer.c
> > > index c06515987e7a..9bf75dee7ff8 100644
> > > --- a/drivers/iio/buffer/industrialio-triggered-buffer.c
> > > +++ b/drivers/iio/buffer/industrialio-triggered-buffer.c
> > > @@ -1,5 +1,5 @@
> > >  // SPDX-License-Identifier: GPL-2.0-only
> > > - /*
> > > +/*
> > >   * Copyright (c) 2012 Analog Devices, Inc.
> > >   *  Author: Lars-Peter Clausen <lars@...afoo.de>
> > >   */
> > >  
> >  
>