linux-kernel - Re: [PATCH v3 4/6] riscv: dts: spacemit: add pwm14

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250526215243-GYA53128@gentoo>
Date: Mon, 26 May 2025 21:52:43 +0000
From: Yixun Lan <dlan@...too.org>
To: Uwe Kleine-König <ukleinek@...nel.org>
Cc: Guodong Xu <guodong@...cstar.com>, robh@...nel.org, krzk+dt@...nel.org,
	conor+dt@...nel.org, paul.walmsley@...ive.com, palmer@...belt.com,
	aou@...s.berkeley.edu, alex@...ti.fr, p.zabel@...gutronix.de,
	drew@...7.com, inochiama@...il.com, geert+renesas@...der.be,
	heylenay@....org, tglx@...utronix.de, hal.feng@...rfivetech.com,
	unicorn_wang@...look.com, duje.mihanovic@...le.hr,
	heikki.krogerus@...ux.intel.com, elder@...cstar.com,
	linux-pwm@...r.kernel.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-riscv@...ts.infradead.org,
	spacemit@...ts.linux.dev
Subject: Re: [PATCH v3 4/6] riscv: dts: spacemit: add pwm14_1 pinctrl setting

Hi Guodong, Uwe,

On 18:54 Mon 26 May     , Uwe Kleine-König wrote:
> On Tue, Apr 29, 2025 at 04:50:46PM +0800, Guodong Xu wrote:
> > diff --git a/arch/riscv/boot/dts/spacemit/k1-pinctrl.dtsi b/arch/riscv/boot/dts/spacemit/k1-pinctrl.dtsi
> > index 283663647a86..195eb8874f3c 100644
> > --- a/arch/riscv/boot/dts/spacemit/k1-pinctrl.dtsi
> > +++ b/arch/riscv/boot/dts/spacemit/k1-pinctrl.dtsi
> > @@ -20,4 +20,11 @@ uart0-2-pins {
> >  			drive-strength = <32>;
> >  		};
> >  	};
> > +	pwm14_1_cfg: pwm14-1-cfg {
> > +		pwm14-1-pins {
> > +			pinmux = <K1_PADCONF(44, 4)>;
> > +			bias-pull-up = <0>;
> > +			drive-strength = <32>;
> > +		};
> > +	};
> 
> There is a newline expected before the pwm14-1-cfg node, isn't there?
> 
Right, I could amend this and fix it while applying this patch
(so if there is no other serious issue, no need to resend)

-- 
Yixun Lan (dlan)