linux-kernel - Re: [PATCH bcachefs-testing] bcachefs: fix goto jumping over guard initializers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPZ5DTE1z=PPm+v718ZfgYg0oJkEKHJ-pxrSjSGTmxQVqzaP7A@mail.gmail.com>
Date: Tue, 27 May 2025 23:09:00 +0530
From: Bharadwaj Raju <bharadwaj.raju777@...il.com>
To: kent.overstreet@...ux.dev
Cc: linux-bcachefs@...r.kernel.org, shuah@...nel.org, 
	linux-kernel@...r.kernel.org, linux-kernel-mentees@...ts.linux.dev
Subject: Re: [PATCH bcachefs-testing] bcachefs: fix goto jumping over guard initializers

Now I'm actually not sure this is the best solution -- the comments in
include/linux/cleanup.h say that gotos and cleanup helpers should never be
mixed in the same function in the first place. So ideally we should not use
these guard helpers until we develop helpers for everything that
we want to clean up using gotos, like printbuf_exit, bch2_trans_put,
and so on, and then switch over everything at once.