linux-kernel - Re: linux-next: Tree for May 27 (drivers/platform/x86/amd/amd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d2ac901b-f7d2-46e6-b977-0ad90faa46f2@kernel.org>
Date: Tue, 27 May 2025 21:43:59 +0200
From: Hans de Goede <hansg@...nel.org>
To: Randy Dunlap <rdunlap@...radead.org>,
 Stephen Rothwell <sfr@...b.auug.org.au>,
 Linux Next Mailing List <linux-next@...r.kernel.org>,
 Pratap Nirujogi <pratap.nirujogi@....com>,
 Benjamin Chan <benjamin.chan@....com>
Cc: Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
 "open list:AMD HETERO CORE HARDWARE FEEDBACK DRIVER"
 <platform-driver-x86@...r.kernel.org>,
 Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
Subject: Re: linux-next: Tree for May 27 (drivers/platform/x86/amd/amd_isp4.c)

Hi,

On 27-May-25 8:56 PM, Randy Dunlap wrote:
> 
> 
> On 5/27/25 3:32 AM, Stephen Rothwell wrote:
>> Hi all,
>>
>> Changes since 20250526:
>>
> 
> on x86_64, when
> # CONFIG_MODULES is not set
> 
> ../drivers/platform/x86/amd/amd_isp4.c: In function 'is_isp_i2c_adapter':
> ../drivers/platform/x86/amd/amd_isp4.c:154:35: error: invalid use of undefined type 'struct module'
>   154 |         return !strcmp(adap->owner->name, "i2c_designware_amdisp");
>       |                                   ^~

Hmm, this should not check the owner->name at all.

Instead the i2c_designware_amdisp should set adap->name to something
unique and then this should check adap->name.

Regards,

Hans