linux-kernel - Re: [PATCH v1] perf pmu: Avoid segv for missing name/alias

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAP-5=fUiWm9kq2fhT-9+8LOmC2Yen9Mw2P8yPLTJH+nk83nmmA@mail.gmail.com>
Date: Tue, 27 May 2025 13:33:35 -0700
From: Ian Rogers <irogers@...gle.com>
To: Namhyung Kim <namhyung@...nel.org>
Cc: Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...hat.com>, 
	Arnaldo Carvalho de Melo <acme@...nel.org>, Mark Rutland <mark.rutland@....com>, 
	Alexander Shishkin <alexander.shishkin@...ux.intel.com>, Jiri Olsa <jolsa@...nel.org>, 
	Adrian Hunter <adrian.hunter@...el.com>, Kan Liang <kan.liang@...ux.intel.com>, 
	James Clark <james.clark@...aro.org>, linux-perf-users@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] perf pmu: Avoid segv for missing name/alias_name in wildcarding

On Fri, Apr 4, 2025 at 11:07 AM Namhyung Kim <namhyung@...nel.org> wrote:
>
> On Wed, Apr 02, 2025 at 02:13:01PM -0700, Ian Rogers wrote:
> > The pmu name or alias_name fields may be NULL and should be skipped if
> > so. This is done in all loops of perf_pmu___name_match except the
> > final wildcard loop which was an oversight.
> >
> > Fixes: c786468a3585 ("perf pmu: Rename name matching for no suffix or wildcard variants")
> > Signed-off-by: Ian Rogers <irogers@...gle.com>
>
> Acked-by: Namhyung Kim <namhyung@...nel.org>

Ping.

Thanks,
Ian

> Thanks,
> Namhyung
>
> > ---
> >  tools/perf/util/pmu.c | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/tools/perf/util/pmu.c b/tools/perf/util/pmu.c
> > index 31f1e617eb20..d27bdf421c19 100644
> > --- a/tools/perf/util/pmu.c
> > +++ b/tools/perf/util/pmu.c
> > @@ -2060,7 +2060,9 @@ static bool perf_pmu___name_match(const struct perf_pmu *pmu, const char *to_mat
> >       }
> >       for (size_t i = 0; i < ARRAY_SIZE(names); i++) {
> >               const char *name = names[i];
> > -
> > +
> > +             if (!name)
> > +                     continue;
> >               if (wildcard && perf_pmu__match_wildcard_uncore(name, to_match))
> >                       return true;
> >               if (!wildcard && perf_pmu__match_ignoring_suffix_uncore(name, to_match))
> > --
> > 2.49.0.504.g3bcea36a83-goog
> >