linux-kernel - Re: [PATCH next V2] KVM: VMX: use __always_inline for is_td_vcpu and is

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <18b805fbe1de59f45b0d61667933f5301cea4f86.camel@intel.com>
Date: Tue, 27 May 2025 21:48:06 +0000
From: "Huang, Kai" <kai.huang@...el.com>
To: "binbin.wu@...ux.intel.com" <binbin.wu@...ux.intel.com>, "Edgecombe, Rick
 P" <rick.p.edgecombe@...el.com>, "eadavis@...com" <eadavis@...com>
CC: "seanjc@...gle.com" <seanjc@...gle.com>, "bp@...en8.de" <bp@...en8.de>,
	"dave.hansen@...ux.intel.com" <dave.hansen@...ux.intel.com>, "hpa@...or.com"
	<hpa@...or.com>, "mingo@...hat.com" <mingo@...hat.com>, "tglx@...utronix.de"
	<tglx@...utronix.de>, "x86@...nel.org" <x86@...nel.org>,
	"pbonzini@...hat.com" <pbonzini@...hat.com>, "kvm@...r.kernel.org"
	<kvm@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH next V2] KVM: VMX: use __always_inline for is_td_vcpu and
 is_td

On Tue, 2025-05-27 at 17:53 +0000, Edgecombe, Rick P wrote:
> On Tue, 2025-05-27 at 16:44 +0800, Edward Adam Davis wrote:
> > is_td() and is_td_vcpu() run in no instrumentation, so use __always_inline
> > to replace inline.
> > 
> > [1]
> > vmlinux.o: error: objtool: vmx_handle_nmi+0x47:
> >         call to is_td_vcpu.isra.0() leaves .noinstr.text section
> > 
> > Fixes: 7172c753c26a ("KVM: VMX: Move common fields of struct vcpu_{vmx,tdx} to a struct")
> > Signed-off-by: Edward Adam Davis <eadavis@...com>
> > ---
> > V1 -> V2: using __always_inline to replace noinstr
> 
> Argh, for some reason the original report was sent just to Paolo and so I didn't
> see this until now:
> https://lore.kernel.org/oe-kbuild-all/202505071640.fUgzT6SF-lkp@intel.com/
> 
> You (or Paolo) might want to add that link for [1]. Fix looks good.
> 
> Tested-by: Rick Edgecombe <rick.p.edgecombe@...el.com>

Also,

Reviewed-by: Kai Huang <kai.huang@...el.com>