| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <SE1P216MB1303B88AE797492E2F04B0A4ED64A@SE1P216MB1303.KORP216.PROD.OUTLOOK.COM> Date: Tue, 27 May 2025 05:07:17 +0000 From: jackson.lee <jackson.lee@...psnmedia.com> To: Nicolas Dufresne <nicolas.dufresne@...labora.com>, "mchehab@...nel.org" <mchehab@...nel.org>, "hverkuil-cisco@...all.nl" <hverkuil-cisco@...all.nl>, "sebastian.fricke@...labora.com" <sebastian.fricke@...labora.com>, "bob.beckett@...labora.com" <bob.beckett@...labora.com>, "dafna.hirschfeld@...labora.com" <dafna.hirschfeld@...labora.com> CC: "linux-media@...r.kernel.org" <linux-media@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, lafley.kim <lafley.kim@...psnmedia.com>, "b-brnich@...com" <b-brnich@...com>, "hverkuil@...all.nl" <hverkuil@...all.nl>, Nas Chung <nas.chung@...psnmedia.com> Subject: RE: [PATCH v2 7/7] media: chips-media: wave5: Fix SError of kernel panic when closed Hi Nicolas > -----Original Message----- > From: Nicolas Dufresne <nicolas.dufresne@...labora.com> > Sent: Saturday, May 24, 2025 2:48 AM > To: jackson.lee <jackson.lee@...psnmedia.com>; mchehab@...nel.org; > hverkuil-cisco@...all.nl; sebastian.fricke@...labora.com; > bob.beckett@...labora.com; dafna.hirschfeld@...labora.com > Cc: linux-media@...r.kernel.org; linux-kernel@...r.kernel.org; lafley.kim > <lafley.kim@...psnmedia.com>; b-brnich@...com; hverkuil@...all.nl; Nas > Chung <nas.chung@...psnmedia.com> > Subject: Re: [PATCH v2 7/7] media: chips-media: wave5: Fix SError of > kernel panic when closed > > Hi, > > > Le jeudi 22 mai 2025 à 16:26 +0900, Jackson.lee a écrit : > > From: Jackson Lee <jackson.lee@...psnmedia.com> > > > > Since applying "Reduce high CPU load" patch, SError of kernel panic > > rarely happened while testing fluster. > > The root cause was to enter suspend mode because timeout of > > autosuspend delay happened. > > This would need to be done ahead of other patches, before it breaks. > Toggling auto-suspend seems suspicious. I'm pretty sure this was always a > bit fishy, so I'm fine with removing that. Normally get/put once > everything is configured should be fine. > Okay Thanks Jackson > > > > [ 48.834439] SError Interrupt on CPU0, code 0x00000000bf000000 -- > > SError [ 48.834455] CPU: 0 UID: 0 PID: 1067 Comm: v4l2h265dec0:sr > > Not tainted 6.12.9-gc9e21a1ebd75-dirty #7 [ 48.834461] Hardware > > name: ti Texas Instruments J721S2 EVM/Texas Instruments J721S2 EVM, > > BIOS 2025.01-00345- gbaf3aaa8ecfa 01/01/2025 [ 48.834464] pstate: > > 20000005 (nzCv daif -PAN -UAO -TCO -DIT -SSBS BTYPE=--) [ 48.834468] > > pc : wave5_dec_clr_disp_flag+0x40/0x80 [wave5] [ 48.834488] lr : > > wave5_dec_clr_disp_flag+0x40/0x80 [wave5] [ 48.834495] sp : > > ffff8000856e3a30 [ 48.834497] x29: ffff8000856e3a30 x28: > > ffff0008093f6010 x27: ffff000809158130 [ 48.834504] x26: > > 0000000000000000 x25: ffff00080b625000 x24: ffff000804a9ba80 [ > > 48.834509] x23: ffff000802343028 x22: ffff000809158150 x21: > > ffff000802218000 [ 48.834513] x20: ffff0008093f6000 x19: > > ffff0008093f6000 x18: 0000000000000000 [ 48.834518] x17: > > 0000000000000000 x16: 0000000000000000 x15: 0000ffff74009618 [ > > 48.834523] x14: 000000010000000c x13: 0000000000000000 x12: > > 0000000000000000 [ 48.834527] x11: ffffffffffffffff x10: > > ffffffffffffffff x9 : ffff000802343028 [ 48.834532] x8 : > > ffff00080b6252a0 x7 : 0000000000000038 x6 : 0000000000000000 [ > > 48.834536] x5 : ffff00080b625060 x4 : 0000000000000000 x3 : > > 0000000000000000 [ 48.834541] x2 : 0000000000000000 x1 : > > ffff800084bf0118 x0 : ffff800084bf0000 [ 48.834547] Kernel panic - > > not syncing: Asynchronous SError Interrupt [ 48.834549] CPU: 0 UID: > > 0 PID: 1067 Comm: v4l2h265dec0:sr Not tainted > > 6.12.9-gc9e21a1ebd75-dirty #7 > > Hopefully you also test on mainline. > > Nicolas > > > [ 48.834554] Hardware name: ti Texas Instruments J721S2 EVM/Texas > > Instruments J721S2 EVM, BIOS 2025.01-00345- gbaf3aaa8ecfa 01/01/2025 [ > > 48.834556] Call trace: > > [ 48.834559] dump_backtrace+0x94/0xec [ 48.834574] > > show_stack+0x18/0x24 [ 48.834579] dump_stack_lvl+0x38/0x90 [ > > 48.834585] dump_stack+0x18/0x24 [ 48.834588] panic+0x35c/0x3e0 [ > > 48.834592] nmi_panic+0x40/0x8c [ 48.834595] > > arm64_serror_panic+0x64/0x70 [ 48.834598] do_serror+0x3c/0x78 [ > > 48.834601] el1h_64_error_handler+0x34/0x4c [ 48.834605] > > el1h_64_error+0x64/0x68 [ 48.834608] > > wave5_dec_clr_disp_flag+0x40/0x80 [wave5] [ 48.834615] > > wave5_vpu_dec_clr_disp_flag+0x54/0x80 [wave5] [ 48.834622] > > wave5_vpu_dec_buf_queue+0x19c/0x1a0 [wave5] [ 48.834628] > > __enqueue_in_driver+0x3c/0x74 [videobuf2_common] [ 48.834639] > > vb2_core_qbuf+0x508/0x61c [videobuf2_common] [ 48.834646] > > vb2_qbuf+0xa4/0x168 [videobuf2_v4l2] [ 48.834656] > > v4l2_m2m_qbuf+0x80/0x238 [v4l2_mem2mem] [ 48.834666] > > v4l2_m2m_ioctl_qbuf+0x18/0x24 [v4l2_mem2mem] [ 48.834673] > > v4l_qbuf+0x48/0x5c [videodev] [ 48.834704] > > __video_do_ioctl+0x180/0x3f0 [videodev] [ 48.834725] > > video_usercopy+0x2ec/0x68c [videodev] [ 48.834745] > > video_ioctl2+0x18/0x24 [videodev] [ 48.834766] v4l2_ioctl+0x40/0x60 > > [videodev] [ 48.834786] __arm64_sys_ioctl+0xa8/0xec [ 48.834793] > > invoke_syscall+0x44/0x100 [ 48.834800] > > el0_svc_common.constprop.0+0xc0/0xe0 > > [ 48.834804] do_el0_svc+0x1c/0x28 > > [ 48.834809] el0_svc+0x30/0xd0 > > [ 48.834813] el0t_64_sync_handler+0xc0/0xc4 [ 48.834816] > > el0t_64_sync+0x190/0x194 [ 48.834820] SMP: stopping secondary CPUs [ > > 48.834831] Kernel Offset: disabled [ 48.834833] CPU features: > > 0x08,00002002,80200000,4200421b [ 48.834837] Memory Limit: none [ > > 49.161404] ---[ end Kernel panic - not syncing: Asynchronous SError > > Interrupt ]--- > > > > Signed-off-by: Jackson Lee <jackson.lee@...psnmedia.com> > > Signed-off-by: Nas Chung <nas.chung@...psnmedia.com> > > --- > > .../platform/chips-media/wave5/wave5-vpu-dec.c | 3 --- > > .../platform/chips-media/wave5/wave5-vpu-enc.c | 3 --- > > .../media/platform/chips-media/wave5/wave5-vpu.c | 2 +- > > .../platform/chips-media/wave5/wave5-vpuapi.c | 16 > > ---------------- > > 4 files changed, 1 insertion(+), 23 deletions(-) > > > > diff --git a/drivers/media/platform/chips-media/wave5/wave5-vpu-dec.c > > b/drivers/media/platform/chips- media/wave5/wave5-vpu-dec.c index > > 421a9e1a6f15..b4b522d7fa84 100644 > > --- a/drivers/media/platform/chips-media/wave5/wave5-vpu-dec.c > > +++ b/drivers/media/platform/chips-media/wave5/wave5-vpu-dec.c > > @@ -1865,9 +1865,6 @@ static int wave5_vpu_open_dec(struct file *filp) > > if (ret) > > goto cleanup_inst; > > > > - if (list_empty(&dev->instances)) > > - pm_runtime_use_autosuspend(inst->dev->dev); > > - > > list_add_tail(&inst->list, &dev->instances); > > > > mutex_unlock(&dev->dev_lock); > > diff --git a/drivers/media/platform/chips-media/wave5/wave5-vpu-enc.c > > b/drivers/media/platform/chips- media/wave5/wave5-vpu-enc.c index > > 52a1a00fd9bb..7f1aa392805f 100644 > > --- a/drivers/media/platform/chips-media/wave5/wave5-vpu-enc.c > > +++ b/drivers/media/platform/chips-media/wave5/wave5-vpu-enc.c > > @@ -1779,9 +1779,6 @@ static int wave5_vpu_open_enc(struct file *filp) > > if (ret) > > goto cleanup_inst; > > > > - if (list_empty(&dev->instances)) > > - pm_runtime_use_autosuspend(inst->dev->dev); > > - > > list_add_tail(&inst->list, &dev->instances); > > > > mutex_unlock(&dev->dev_lock); > > diff --git a/drivers/media/platform/chips-media/wave5/wave5-vpu.c > > b/drivers/media/platform/chips-media/wave5/wave5- > > vpu.c > > index a2c09523d76b..24a9001966e7 100644 > > --- a/drivers/media/platform/chips-media/wave5/wave5-vpu.c > > +++ b/drivers/media/platform/chips-media/wave5/wave5-vpu.c > > @@ -368,7 +368,7 @@ static int wave5_vpu_probe(struct platform_device > *pdev) > > dev_info(&pdev->dev, "Product Code: 0x%x\n", dev- > >product_code); > > dev_info(&pdev->dev, "Firmware Revision: %u\n", fw_revision); > > > > - pm_runtime_set_autosuspend_delay(&pdev->dev, 100); > > + pm_runtime_set_autosuspend_delay(&pdev->dev, 500); > > pm_runtime_use_autosuspend(&pdev->dev); > > pm_runtime_enable(&pdev->dev); > > wave5_vpu_sleep_wake(&pdev->dev, true, NULL, 0); diff --git > > a/drivers/media/platform/chips-media/wave5/wave5-vpuapi.c > > b/drivers/media/platform/chips-media/wave5/wave5- > > vpuapi.c > > index d7318d596b73..1f7f4d214b3c 100644 > > --- a/drivers/media/platform/chips-media/wave5/wave5-vpuapi.c > > +++ b/drivers/media/platform/chips-media/wave5/wave5-vpuapi.c > > @@ -207,8 +207,6 @@ int wave5_vpu_dec_close(struct vpu_instance *inst, > u32 *fail_res) > > int retry = 0; > > struct vpu_device *vpu_dev = inst->dev; > > int i; > > - int inst_count = 0; > > - struct vpu_instance *inst_elm; > > struct dec_output_info dec_info; > > > > *fail_res = 0; > > @@ -265,12 +263,6 @@ int wave5_vpu_dec_close(struct vpu_instance *inst, > u32 *fail_res) > > } > > > > wave5_vdi_free_dma_memory(vpu_dev, &p_dec_info->vb_task); > > - > > - list_for_each_entry(inst_elm, &vpu_dev->instances, list) > > - inst_count++; > > - if (inst_count == 1) > > - pm_runtime_dont_use_autosuspend(vpu_dev->dev); > > - > > mutex_destroy(&inst->feed_lock); > > > > unlock_and_return: > > @@ -738,8 +730,6 @@ int wave5_vpu_enc_close(struct vpu_instance *inst, > u32 *fail_res) > > int ret; > > int retry = 0; > > struct vpu_device *vpu_dev = inst->dev; > > - int inst_count = 0; > > - struct vpu_instance *inst_elm; > > > > *fail_res = 0; > > if (!inst->codec_info) > > @@ -782,12 +772,6 @@ int wave5_vpu_enc_close(struct vpu_instance *inst, > u32 *fail_res) > > } > > > > wave5_vdi_free_dma_memory(vpu_dev, &p_enc_info->vb_task); > > - > > - list_for_each_entry(inst_elm, &vpu_dev->instances, list) > > - inst_count++; > > - if (inst_count == 1) > > - pm_runtime_dont_use_autosuspend(vpu_dev->dev); > > - > > mutex_unlock(&vpu_dev->hw_lock); > > pm_runtime_put_sync(inst->dev->dev); > >
Powered by blists - more mailing lists