linux-kernel - Re: [PATCH v1] ext4: remove unused EXT_STATS macro from ext4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2e0a6686-f953-4a38-87e1-612a61825103@huawei.com>
Date: Tue, 27 May 2025 14:11:44 +0800
From: Baokun Li <libaokun1@...wei.com>
To: Baolin Liu <liubaolin12138@....com>, <tytso@....edu>,
	<adilger.kernel@...ger.ca>
CC: <linux-ext4@...r.kernel.org>, <linux-kernel@...r.kernel.org>, Baolin Liu
	<liubaolin@...inos.cn>, Yang Erkun <yangerkun@...wei.com>
Subject: Re: [PATCH v1] ext4: remove unused EXT_STATS macro from
 ext4_extents.h

On 2025/5/27 13:38, Baolin Liu wrote:
> From: Baolin Liu <liubaolin@...inos.cn>
>
> The EXT_STATS macro in fs/ext4/ext4_extents.h has been defined
> but never used in the codebase since its introduction. This patch
> removes it.
>
> Analysis:
> 1. No references found in fs/ext4/ or other kernel code.
> 2. No impact on compilation or functionality.
> 3. Git history shows it was never utilized.
>
> Signed-off-by: Baolin Liu <liubaolin@...inos.cn>
Good spotting! Feel free to add:

Reviewed-by: Baokun Li <libaokun1@...wei.com>
> ---
>   fs/ext4/ext4_extents.h | 7 -------
>   1 file changed, 7 deletions(-)
>
> diff --git a/fs/ext4/ext4_extents.h b/fs/ext4/ext4_extents.h
> index 26435f3a3094..c484125d963f 100644
> --- a/fs/ext4/ext4_extents.h
> +++ b/fs/ext4/ext4_extents.h
> @@ -30,13 +30,6 @@
>    */
>   #define CHECK_BINSEARCH__
>   
> -/*
> - * If EXT_STATS is defined then stats numbers are collected.
> - * These number will be displayed at umount time.
> - */
> -#define EXT_STATS_
> -
> -
>   /*
>    * ext4_inode has i_block array (60 bytes total).
>    * The first 12 bytes store ext4_extent_header;