linux-kernel - Re: [PATCH] Fix comment for virtio-9p

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2636618a-5000-449a-bc2d-f7bf253bf26d@tls.msk.ru>
Date: Tue, 27 May 2025 09:11:36 +0300
From: Michael Tokarev <mjt@....msk.ru>
To: dancer@...ian.org, mst@...hat.com
Cc: qemu-devel@...gnu.org, adelva@...gle.com, uekawa@...omium.org,
 linux-kernel@...r.kernel.org, virtualization@...ts.linux.dev,
 kvm@...r.kernel.org
Subject: Re: [PATCH] Fix comment for virtio-9p

27.05.2025 07:11, dancer@...ian.org wrote:
> From: Junichi Uekawa <uekawa@...omium.org>
> 
> virtio-9p is not a console protocol, it's a file sharing protocol. Seems
> like an artifact of old copy-and-paste error.

> -#define VIRTIO_ID_9P			9 /* 9p virtio console */
> +#define VIRTIO_ID_9P			9 /* virtio 9p */

While the old one was obviously wrong, I don't think the new
wording makes much sense, since it merely repeats the name of
the constant :)

How about "virtio 9p file sharing protocol" instead ? :)

/mjt