linux-kernel - Re: [PATCH] Fix comment for virtio-9p

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87bjrea7x3.dancerj-dancer@netfort.gr.jp>
Date: Tue, 27 May 2025 15:23:36 +0900
From: Junichi Uekawa <dancer@...fort.gr.jp>
To: Michael Tokarev <mjt@....msk.ru>
Cc: dancer@...ian.org,
	mst@...hat.com,
	qemu-devel@...gnu.org,
	adelva@...gle.com,
	uekawa@...omium.org,
	linux-kernel@...r.kernel.org,
	virtualization@...ts.linux.dev,
	kvm@...r.kernel.org
Subject: Re: [PATCH] Fix comment for virtio-9p

On Tue, 27 May 2025 15:11:36 +0900,
Michael Tokarev wrote:
> 
> 27.05.2025 07:11, dancer@...ian.org wrote:
> > From: Junichi Uekawa <uekawa@...omium.org>
> > 
> > virtio-9p is not a console protocol, it's a file sharing protocol. Seems
> > like an artifact of old copy-and-paste error.
> 
> > -#define VIRTIO_ID_9P			9 /* 9p virtio console */
> > +#define VIRTIO_ID_9P			9 /* virtio 9p */
> 
> While the old one was obviously wrong, I don't think the new
> wording makes much sense, since it merely repeats the name of
> the constant :)
> 
> How about "virtio 9p file sharing protocol" instead ? :)

Sounds better!

I also found another case, added to the follow-up.