linux-kernel - Re: [PATCH V3 2/2] mm/khugepaged: clean up refcount check using folio_expected_ref

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b4d3b436-380a-4f01-8f00-4baaf7ed5a8c@linux.alibaba.com>
Date: Tue, 27 May 2025 14:26:43 +0800
From: Baolin Wang <baolin.wang@...ux.alibaba.com>
To: Shivank Garg <shivankg@....com>, akpm@...ux-foundation.org,
 david@...hat.com, linux-mm@...ck.org, linux-kernel@...r.kernel.org
Cc: ziy@...dia.com, lorenzo.stoakes@...cle.com, Liam.Howlett@...cle.com,
 npache@...hat.com, ryan.roberts@....com, dev.jain@....com,
 fengwei.yin@...el.com, bharata@....com
Subject: Re: [PATCH V3 2/2] mm/khugepaged: clean up refcount check using
 folio_expected_ref_count()



On 2025/5/27 02:28, Shivank Garg wrote:
> Use folio_expected_ref_count() instead of open-coded logic in
> is_refcount_suitable(). This avoids code duplication and improves
> clarity.
> 
> Drop is_refcount_suitable() as it is no longer needed.
> 
> Suggested-by: David Hildenbrand <david@...hat.com>
> Acked-by: David Hildenbrand <david@...hat.com>
> Signed-off-by: Shivank Garg <shivankg@....com>

Nice cleanup.
Reviewed-by: Baolin Wang <baolin.wang@...ux.alibaba.com>