linux-kernel - Re: [PATCH v2 3/4] dt-bindings: crypto: fsl,sec-v4.0: Add power domains for iMX8QM and iMX8QXP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <15dcde73-3c0e-4cc9-934f-4dbabd92905e@kernel.org>
Date: Tue, 27 May 2025 09:19:22 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: John Ernberg <john.ernberg@...ia.se>, Horia Geantă
 <horia.geanta@....com>, Pankaj Gupta <pankaj.gupta@....com>,
 Gaurav Jain <gaurav.jain@....com>, Herbert Xu <herbert@...dor.apana.org.au>,
 "David S . Miller" <davem@...emloft.net>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Shawn Guo <shawnguo@...nel.org>,
 Sascha Hauer <s.hauer@...gutronix.de>
Cc: Frank Li <Frank.li@....com>,
 Pengutronix Kernel Team <kernel@...gutronix.de>,
 Fabio Estevam <festevam@...il.com>,
 Thomas Richard <thomas.richard@...tlin.com>,
 "linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>,
 "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 "imx@...ts.linux.dev" <imx@...ts.linux.dev>,
 "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v2 3/4] dt-bindings: crypto: fsl,sec-v4.0: Add power
 domains for iMX8QM and iMX8QXP

On 27/05/2025 09:16, John Ernberg wrote:
> 
> diff --git a/Documentation/devicetree/bindings/crypto/fsl,sec-v4.0.yaml b/Documentation/devicetree/bindings/crypto/fsl,sec-v4.0.yaml
> index 75afa441e019..a3c938eb553e 100644
> --- a/Documentation/devicetree/bindings/crypto/fsl,sec-v4.0.yaml
> +++ b/Documentation/devicetree/bindings/crypto/fsl,sec-v4.0.yaml
> @@ -48,6 +48,9 @@ properties:
>                - fsl,imx6ul-caam
>                - fsl,sec-v5.0
>            - const: fsl,sec-v4.0
> +      - items:
> +          - const: fsl,imx8qm-caam

That's part of previous enum, no?

> +          - const: fsl,sec-v4.0
>        - const: fsl,sec-v4.0
>  
>    reg:
> @@ -77,6 +80,9 @@ properties:
>    interrupts:
>      maxItems: 1
>  
> +  power-domains:
> +    maxItems: 1
> +
>    fsl,sec-era:
>      description: Defines the 'ERA' of the SEC device.
>      $ref: /schemas/types.yaml#/definitions/uint32
> @@ -108,6 +114,9 @@ patternProperties:
>            - items:
>                - const: fsl,sec-v5.0-job-ring
>                - const: fsl,sec-v4.0-job-ring
> +          - items:
> +              - const: fsl,imx8qm-job-ring

Combine with previous entry into enum.

> +              - const: fsl,sec-v4.0-job-ring
>            - const: fsl,sec-v4.0-job-ring
>  

Best regards,
Krzysztof