linux-kernel - Re: [PATCH] wifi: iwlwifi: cfg: Limit cb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fadefef6-5e16-4cc3-87d5-33e94ac1ad1a@kylinos.cn>
Date: Tue, 27 May 2025 16:06:22 +0800
From: Pei Xiao <xiaopei01@...inos.cn>
To: Johannes Berg <johannes@...solutions.net>,
 miriam.rachel.korenblit@...el.com, emmanuel.grumbach@...el.com,
 linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] wifi: iwlwifi: cfg: Limit cb_size to valid range


在 2025/5/23 15:59, Johannes Berg 写道:
> On Fri, 2025-05-23 at 14:04 +0800, Pei Xiao wrote:
>>  
>> -	WARN_ON(RX_QUEUE_CB_SIZE(iwl_trans_get_num_rbds(trans)) > 12);
>> +	cb_size = RX_QUEUE_CB_SIZE(iwl_trans_get_num_rbds(trans));
>> +	if (unlikely(cb_size > 12)) {
>> +		WARN_ON(1);
>>
> What's wrong with "if (WARN_ON(...))"?!?

thanks!

V2:

https://lore.kernel.org/lkml/7b373a4426070d50b5afb3269fd116c18ce3aea8.1748332709.git.xiaopei01@kylinos.cn/

> Not that I think it even really needs to be there but I guess working
> around a compiler warning could be worth it.
>
> johannes
Pei.Thanks!