linux-kernel - Re: [PATCH RFC 5/6] riscv: dts: thead: Add PVT node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0dc42c81-a082-4fce-a447-32995b75f1c9@samsung.com>
Date: Tue, 27 May 2025 10:54:42 +0200
From: "Michal Wilczynski/Kernel (PLT) /SRPOL/Engineer/Samsung Electronics"
	<m.wilczynski@...sung.com>
To: Drew Fustini <drew@...7.com>
Cc: Uwe Kleine-König <ukleinek@...nel.org>, Miguel Ojeda
	<ojeda@...nel.org>, Alex Gaynor <alex.gaynor@...il.com>, Boqun Feng
	<boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>,
	Björn Roy Baron <bjorn3_gh@...tonmail.com>, Benno Lossin
	<benno.lossin@...ton.me>, Andreas Hindborg <a.hindborg@...nel.org>, Alice
	Ryhl <aliceryhl@...gle.com>, Trevor Gross <tmgross@...ch.edu>, Danilo
	Krummrich <dakr@...nel.org>, Guo Ren <guoren@...nel.org>, Fu Wei
	<wefu@...hat.com>, Rob Herring <robh@...nel.org>, Krzysztof Kozlowski
	<krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, Paul Walmsley
	<paul.walmsley@...ive.com>, Palmer Dabbelt <palmer@...belt.com>, Albert Ou
	<aou@...s.berkeley.edu>, Alexandre Ghiti <alex@...ti.fr>, Marek Szyprowski
	<m.szyprowski@...sung.com>, linux-kernel@...r.kernel.org,
	linux-pwm@...r.kernel.org, rust-for-linux@...r.kernel.org,
	linux-riscv@...ts.infradead.org, devicetree@...r.kernel.org
Subject: Re: [PATCH RFC 5/6] riscv: dts: thead: Add PVT node


W dniu 27.05.2025 o 10:00, Drew Fustini pisze:
> On Sat, May 24, 2025 at 11:14:59PM +0200, Michal Wilczynski wrote:
>> Add PVT DT node for thermal sensor.
>>
>> Signed-off-by: Michal Wilczynski <m.wilczynski@...sung.com>
>> ---
>>   arch/riscv/boot/dts/thead/th1520.dtsi | 11 +++++++++++
>>   1 file changed, 11 insertions(+)
>>
>> diff --git a/arch/riscv/boot/dts/thead/th1520.dtsi b/arch/riscv/boot/dts/thead/th1520.dtsi
>> index f24e12d7259fabcfbdc2dfa966d759db06684ab4..faf5c3aaf209b24cd99ddc377a88e08a8cce24fe 100644
>> --- a/arch/riscv/boot/dts/thead/th1520.dtsi
>> +++ b/arch/riscv/boot/dts/thead/th1520.dtsi
>> @@ -648,6 +648,17 @@ padctrl_aosys: pinctrl@...ff4a000 {
>>   			thead,pad-group = <1>;
>>   		};
>>   
>> +		pvt: pvt@...ff4e000 {
>> +			compatible = "moortec,mr75203";
>> +			reg = <0xff 0xfff4e000 0x0 0x80>,
>> +			      <0xff 0xfff4e080 0x0 0x100>,
>> +			      <0xff 0xfff4e180 0x0 0x680>,
>> +			      <0xff 0xfff4e800 0x0 0x600>;
>> +			reg-names = "common", "ts", "pd", "vm";
>> +			clocks = <&aonsys_clk>;
>> +			#thermal-sensor-cells = <1>;
>> +		};
>> +
>>   		gpio@...ff52000 {
>>   			compatible = "snps,dw-apb-gpio";
>>   			reg = <0xff 0xfff52000 0x0 0x1000>;
>>
>> -- 
>> 2.34.1
>>
> I found that on my lpi4a that boot while hang after applying this patch.
> I think that it is related to clocks as boot finished okay when using
> clk_ignore_unused on the kernel cmdline. Do you happen have that in your
> kernel cmdline?

Right I had that option enabled, that's why I've missed this. Thanks for

letting me know ! I'll remove this option for future testing.

>
> I need to investigate further to understand which clocks are causing the
> problem.


No problem I can look into that as well, most likely towards the end

of the week as I'm travelling and don't have access to the board.


>
> Thanks,
> Drew
>