linux-kernel - RE: [PATCH v1] net/ncsi: fix buffer overflow in getting version id

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <SEZPR04MB6853F47821DED8F259FBD975B064A@SEZPR04MB6853.apcprd04.prod.outlook.com>
Date: Tue, 27 May 2025 02:23:24 +0000
From: Jerry C Chen/WYHQ/Wiwynn <Jerry_C_Chen@...ynn.com>
To: Paul Fertser <fercerpav@...il.com>
CC: "patrick@...cx.xyz" <patrick@...cx.xyz>,
        Samuel Mendoza-Jonas
	<sam@...dozajonas.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet
	<edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni
	<pabeni@...hat.com>, Simon Horman <horms@...nel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "stable@...r.kernel.org" <stable@...r.kernel.org>
Subject: RE: [PATCH v1] net/ncsi: fix buffer overflow in getting version id

Hi Paul,

Thank for your reply and suggestions.
Since the net-next is closed now: https://netdev.bots.linux.dev/net-next.html
I will submit new patch(new mail thread) while it re-open.
BTW, seems the re-open day is wrong: "Closed until April 7th", may I know which day will it open? Thanks.

> -----Original Message-----
> From: Paul Fertser <fercerpav@...il.com>
> Sent: Tuesday, May 27, 2025 4:15 AM
> To: Jerry C Chen/WYHQ/Wiwynn <Jerry_C_Chen@...ynn.com>
> Cc: patrick@...cx.xyz; Samuel Mendoza-Jonas <sam@...dozajonas.com>;
> David S. Miller <davem@...emloft.net>; Eric Dumazet
> <edumazet@...gle.com>; Jakub Kicinski <kuba@...nel.org>; Paolo Abeni
> <pabeni@...hat.com>; Simon Horman <horms@...nel.org>;
> netdev@...r.kernel.org; linux-kernel@...r.kernel.org; stable@...r.kernel.org
> Subject: Re: [PATCH v1] net/ncsi: fix buffer overflow in getting version id
> 
>  [External Sender]
> 
> Hi Jerry,
> 
> On Fri, May 23, 2025 at 07:32:26AM +0000, Jerry C Chen/WYHQ/Wiwynn
> wrote:
> > Sorry for late replay, it takes some effort to change company policy of the
> proprietary.
> 
> I can imagine! However it's not necessary to send patches from corporate
> e-mail address via the corporate mail server, you can just send from your own
> personal account with the appropriate From:
> specification to attribute it to your corporate address[0].
> 
> > For the questions:
> 
> Please consider just using standard inline method of replying in the future,
> letting your MUA quote the original message for context properly.
> 
> > 1. What upstream tree did you intend it for and why?
> >  - Linux mainline
> >   We are developing openBMC with kernel-6.6.
> >   For submitting patch to kernel-6.6 stable tree, it should exist in mainline
> first.
> >   Reference:
> > https://urldefense.com/v3/__https://github.com/openbmc/linux/commits/d
> >
> ev-6.6/__;!!ObgLwW8oGsQ!lfBTzKPEhZloN2Uwc85U1tsMWw41Yq8dTkG9oxjckT
> okV1
> > 1cR1AQaKFRrIwg9G02e1CpUC_SUX9aFCoEREqXU-Q$
> 
> Indeed, and the process of submitting to mainline implies that for each
> subsystem there's a tree which subsystem maintainer(s) use for the integration
> and which is later offered as a the pull request for the upcoming version,
> usually it's called {subsystem}-next (also such trees get tested together being
> merged into linux-next regularly). I guess in this case you should make sure
> your patch applies to net-next (and makes sense there). Neither the current
> submission[1] nor the previous one[2] were applicable (see
> "netdev/tree_selection success Guessing tree name failed - patch did not
> apply" and indeed I tried to "git am" it manually to what was "net-next" back
> then and it failed.
> 
> > 2. Have you seen such cards in the wild? It wouldn't harm mentioning
> > specific examples in the commit message to probably help people
> > searching for problems specific to them later. You can also consider
> > adding Fixes: and Cc: stable tags if this bugfix solves a real issue
> > and should be backported to stable kernels.
> >  - This NIC is developed by META terminus team and the problematic string
> is:
> >  The channel Version Str : 24.12.08-000  I will update it to commit
> > message later.
> 
> I see, thank you. Sigh, this 12 characters limit doesn't seem to make much
> sense, too restrictive to fit a useful part of "git describe --tags" even, but it is
> what it is...
> 
> [0]
> https://urldefense.com/v3/__https://www.kernel.org/doc/html/latest/process/
> submitting-patches.html*from-line__;Iw!!ObgLwW8oGsQ!lfBTzKPEhZloN2Uwc8
> 5U1tsMWw41Yq8dTkG9oxjckTokV11cR1AQaKFRrIwg9G02e1CpUC_SUX9aFCoE
> FjZPgHI$
> [1]
> https://urldefense.com/v3/__https://patchwork.kernel.org/project/netdevbpf/p
> atch/20250515083448.3511588-1-Jerry_C_Chen@...ynn.com/__;!!ObgLwW8
> oGsQ!lfBTzKPEhZloN2Uwc85U1tsMWw41Yq8dTkG9oxjckTokV11cR1AQaKFRrIw
> g9G02e1CpUC_SUX9aFCoEd6rkbGA$
> [2]
> https://urldefense.com/v3/__https://patchwork.kernel.org/project/netdevbpf/p
> atch/20250227055044.3878374-1-Jerry_C_Chen@...ynn.com/__;!!ObgLwW8
> oGsQ!lfBTzKPEhZloN2Uwc85U1tsMWw41Yq8dTkG9oxjckTokV11cR1AQaKFRrIw
> g9G02e1CpUC_SUX9aFCoEVccOzuI$