Message-ID: <a42e05b9-7568-4ebd-8797-c635c07d1884@lucifer.local>
Date: Tue, 27 May 2025 10:37:47 +0100
From: Lorenzo Stoakes <lorenzo.stoakes@...cle.com>
To: Alexandre Ghiti <alex@...ti.fr>
Cc: Ryan Roberts <ryan.roberts@....com>,
        Alexandre Ghiti <alexghiti@...osinc.com>,
        Will Deacon <will@...nel.org>,
        Catalin Marinas <catalin.marinas@....com>,
        Mark Rutland <mark.rutland@....com>,
        Matthew Wilcox <willy@...radead.org>,
        Paul Walmsley <paul.walmsley@...ive.com>,
        Palmer Dabbelt <palmer@...belt.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-riscv@...ts.infradead.org, linux-mm@...ck.org
Subject: Re: [PATCH v5 0/9] Merge arm64/riscv hugetlbfs contpte support

Andrew - does taking this proposed MAINTAINERS change through the riscv tree
work for you?

This series introduces the files being added there, so it seems sensible to add
the MAINTAINERS change to this series.

And I believe this series is intended to be taken through the riscv tree so
seems sensible to do it there?

Proposed entry is 'MEMORY MANAGEMENT - CONTPTE (CONTIGUOUS PTE SUPPORT)', which
is explicitly relevant for arm64, riscv.

Thanks!

On Tue, May 27, 2025 at 11:25:57AM +0200, Alexandre Ghiti wrote:
> Hi Lorenzo,
>
> On 5/21/25 16:57, Lorenzo Stoakes wrote:
[snip]
> > So right now it seems the files would consist of:
> >
> > include/linux/hugetlb_contpte.h
> > mm/hugetlb_contpte.c
> >
> > Is this correct?
>
>
> For now, it is, yes. When this first series gets merged, I would come up
> with another series that will introduce other files for riscv to support thp
> contpte based on the arm64 implementation.

Cool!

>
>
> >
> > Is this series intended to be taken by Andrew or through an arch tree?
>
>
> I can pick it up in the riscv tree once I have Acked-by from arm64
> maintainers.

Have pinged Andrew above on this, you'd need an acked-by from mm people also of
course.

But I guess what makes sense is to take this as a patch in the next respin of
this series that actually introduces this stuff.

So if Andrew took it, he'd have to take the whole series I would say.

>
>
> >
> > And who would you sensibly propose for M's and R's?
>
>
> Ryan is definitely a M, I would be happy to help as M too but if needed, a R
> is enough for me.

Ryan understands this area better than I do, so I would say it's up to him as to
whether he thinks this makes sense.

>
>
> >
> > If we are definitely adding things that sit outside hugetlb or anything
> > arch-specific, and is in fact generic mm code, then yes this should be a
> > section.
> >
> > Does contpte stand for 'Contiguous PTE'?
>
>
> Yes, that's the name arm64 gave to this feature (more understandable than
> svnapot for the riscv feature).

Cheers!

svnapot, guys... what? :P

>
>
> >
> > Then entry could perhaps be:
> >
> > MEMORY MANAGEMENT - CONTPTE (CONTIGUOUS PTE SUPPORT)
> >
> > I'd say this entry should probably be added as a patch in this series.
> >
> > If you give me a list of R's and M's and confirm those files I can very quickly
> > copy/pasta from an existing entry and then you could respin (and cc my work mail
> > for the series :P) and include that as an additional patch?
>
>
> You can do that or I can do it on my own based on your previous patches, as
> you prefer.

I absolutely prefer you to do the work haha! ;)

Please cc- me on the next respin with this change in and I can take a look.

>
>
> >
> > Happy to ACK that in that case.
>
>
> Thanks for jumping in!

No problem!

>
> Alex
>
>
> >
> >
> > > > [1] https://lore.kernel.org/linux-riscv/20240508191931.46060-1-alexghiti@rivosinc.com/
> > > >
> > > > Thanks,
> > > >
> > > > Alex
> > > >
> > > > > Will
> > Cheers, Lorenzo
> >

Cheers, Lorenzo

Powered by blists - more mailing lists