linux-kernel - Re: [PATCH] mm, list_lru: refactor the locking code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <13AF220A-3792-491A-B5C2-36044C450402@linux.dev>
Date: Tue, 27 May 2025 10:36:02 +0800
From: Muchun Song <muchun.song@...ux.dev>
To: Kairui Song <kasong@...cent.com>
Cc: linux-mm@...ck.org,
 Andrew Morton <akpm@...ux-foundation.org>,
 Johannes Weiner <hannes@...xchg.org>,
 Roman Gushchin <roman.gushchin@...ux.dev>,
 Chengming Zhou <zhouchengming@...edance.com>,
 Qi Zheng <zhengqi.arch@...edance.com>,
 linux-kernel@...r.kernel.org,
 kernel test robot <lkp@...el.com>,
 Julia Lawall <julia.lawall@...ia.fr>
Subject: Re: [PATCH] mm, list_lru: refactor the locking code



> On May 27, 2025, at 02:06, Kairui Song <ryncsn@...il.com> wrote:
> 
> From: Kairui Song <kasong@...cent.com>
> 
> Cocci is confused by the try lock then release RCU and return logic
> here. So separate the try lock part out into a standalone helper. The
> code is easier to follow too.
> 
> No feature change, fixes:
> 
> cocci warnings: (new ones prefixed by >>)
>>> mm/list_lru.c:82:3-9: preceding lock on line 77
>>> mm/list_lru.c:82:3-9: preceding lock on line 77
>   mm/list_lru.c:82:3-9: preceding lock on line 75
>   mm/list_lru.c:82:3-9: preceding lock on line 75
> 
> Reported-by: kernel test robot <lkp@...el.com>
> Reported-by: Julia Lawall <julia.lawall@...ia.fr>
> Closes: https://lore.kernel.org/r/202505252043.pbT1tBHJ-lkp@intel.com/
> Signed-off-by: Kairui Song <kasong@...cent.com>

Reviewed-by: Muchun Song <muchun.song@...ux.dev>

Thanks.