linux-kernel - Re: [PATCH] devres: Move remaining devm_alloc_percpu and devm_device_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aDWdXT36Ucxk0O63@smile.fi.intel.com>
Date: Tue, 27 May 2025 14:09:17 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Pei Xiao <xiaopei01@...inos.cn>
Cc: gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org,
	rafael@...nel.org, dakr@...nel.org, bartosz.golaszewski@...aro.org
Subject: Re: [PATCH] devres: Move remaining devm_alloc_percpu and
 devm_device_add_group to devres.h

On Tue, May 27, 2025 at 05:41:21PM +0800, Pei Xiao wrote:
> 在 2025/5/22 20:54, Andy Shevchenko 写道:
> > On Thu, May 22, 2025 at 05:01:26PM +0800, Pei Xiao wrote:

...

> >> -void __percpu *__devm_alloc_percpu(struct device *dev, size_t size,
> >> -				   size_t align);
> >> -void devm_free_percpu(struct device *dev, void __percpu *pdata);
> > Don't you need to cleanup the header inclusions as well?
> 
> no, I think we don't need to cleanup .
> 
> #include <linux/lockdep.h> include #include <asm/percpu.h>
> 
> only move #include <asm/percpu.h> to linux/device/devres.h for
> 
> build error.

It's not needed for the build error fixing as far as I understood it. __percpu
is defined in another header.

...

> >> -int __must_check devm_device_add_group(struct device *dev,
> >> -				       const struct attribute_group *grp);
> > I'm not sure about this. The percpu seems standalone piece, but this has
> > relations with the other group related definitions just above.
> 
> I'm also not sure if this devm_device_add_group needs to be moved, 
> 
> which is why I haven't replied to you yet

Fair enough.

...

> >> +#include <linux/sysfs.h>
> it's redundant.
> >> +#include <asm/percpu.h>
> > What for are these new inclusions, please?
> for percpu.

It does not define __percpu.

> >> +void devm_free_percpu(struct device *dev, void __percpu *pdata);
> > Please, take your time to understand what is behind the __percpu and
> > why the asm/percpu.h is redundant here.
> 
> If this header file is missing, there will be a compilation error. 

Right. But this is wrong header for the purpose.

> Which header file should I include?

The one that defines it, hint:
https://elixir.bootlin.com/linux/v6.15/A/ident/__percpu

> I've found that including <asm/percpu.h> does resolve my compilation issue.

-- 
With Best Regards,
Andy Shevchenko