linux-kernel - Re: [PATCH 2/2] arm64: dts: renesas: r9a09g057h44-rzv2h-evk: Enable USB2.0 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CA+V-a8v6hBveByhgsx2g1Lv=UVeBuMMDjzYkXmqyc5Wzo_=LEw@mail.gmail.com>
Date: Tue, 27 May 2025 12:35:18 +0100
From: "Lad, Prabhakar" <prabhakar.csengg@...il.com>
To: Geert Uytterhoeven <geert@...ux-m68k.org>
Cc: Magnus Damm <magnus.damm@...il.com>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	linux-renesas-soc@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org, Biju Das <biju.das.jz@...renesas.com>, 
	Fabrizio Castro <fabrizio.castro.jz@...esas.com>, 
	Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
Subject: Re: [PATCH 2/2] arm64: dts: renesas: r9a09g057h44-rzv2h-evk: Enable
 USB2.0 support

Hi Geert,

Thank you for the review.

On Fri, May 23, 2025 at 9:13 AM Geert Uytterhoeven <geert@...ux-m68k.org> wrote:
>
> Hi Prabhakar,
>
> On Thu, 15 May 2025 at 20:31, Prabhakar <prabhakar.csengg@...il.com> wrote:
> > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
> >
> > Enable USB2.0 support on the RZ/V2H EVK board, CN3 supports
> > host only operation and CN2 supports host/function operation.
> >
> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
>
> Thanks for your patch!
>
> > --- a/arch/arm64/boot/dts/renesas/r9a09g057h44-rzv2h-evk.dts
> > +++ b/arch/arm64/boot/dts/renesas/r9a09g057h44-rzv2h-evk.dts
>
> > @@ -303,6 +326,28 @@ sd1_cd {
> >                         pinmux = <RZV2H_PORT_PINMUX(9, 4, 14)>; /* SD1_CD */
> >                 };
> >         };
> > +
> > +       usb20_pins: usb20 {
> > +               vbus {
> > +                       pinmux = <RZV2H_PORT_PINMUX(9, 5, 14)>; /* VBUS */
> > +               };
> > +
> > +               ovc {
>
> Moving up to preserve sort order.
>
Thank you for taking care of this (and below).

Cheers,
Prabhakar

> > +                       pinmux =  <RZV2H_PORT_PINMUX(9, 6, 14)>; /* OVC */
> > +                       bias-pull-up;
> > +               };
> > +       };
> > +
> > +       usb21_pins: usb21 {
> > +               vbus {
> > +                       pinmux = <RZV2H_PORT_PINMUX(6, 6, 14)>; /* VBUS */
> > +               };
> > +
> > +               ovc {
>
> Moving up to preserve sort order.
>
> > +                       pinmux = <RZV2H_PORT_PINMUX(6, 7, 14)>; /* OVC */
> > +                       bias-pull-up;
> > +               };
> > +       };
> >  };
> >
> >  &qextal_clk {
>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@...der.be>
> i.e. will queue in renesas-devel for v6.17 with the above fixed.
>
> Gr{oetje,eeting}s,
>
>                         Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds