linux-kernel - Re: [GIT PULL] platform-drivers-x86 for v6.16-1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aDWq/U57DO7fMu4K@duo.ucw.cz>
Date: Tue, 27 May 2025 14:07:25 +0200
From: Pavel Machek <pavel@....cz>
To: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
Cc: Linus Torvalds <torvalds@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>,
	PDx86 <platform-driver-x86@...r.kernel.org>,
	Hans de Goede <hdegoede@...hat.com>,
	Andy Shevchenko <andy@...nel.org>,
	Guenter Roeck <linux@...ck-us.net>, Jiri Kosina <jikos@...nel.org>,
	Benjamin Tissoires <bentiss@...nel.org>,
	Sebastian Reichel <sre@...nel.org>
Subject: Re: [GIT PULL] platform-drivers-x86 for v6.16-1

Hi!

> warning to hid-asus. I'm expecting Pavel might want object the approach
> used in the tuxedo driver, I largely relied on my co-maintainer Hans'
> opinion on what to do with that change as he was much more familiar with
> that discussion, and the pros and cons of each approach.


>  drivers/platform/x86/tuxedo/nb04/wmi_ab.c          |  923 +++++
>  drivers/platform/x86/tuxedo/nb04/wmi_util.c        |   91 +
>  drivers/platform/x86/tuxedo/nb04/wmi_util.h        |  109 +

Yes, I'd preffer this not to go in.

Reasons:

1) Normally, keyboard backlight is handled by LED subsystem. This was
not even Cc-ed to LED list.

2) It introduces new kernel API. Unfortunately, that API is not
documented in the kernel and is very much unlike anything else we have
in the kernel.

3) The code is not modular in any way, so the crazy API code is mixed
with real driver code, making reuse hard.

4) We don't have reasonable support for the new API in the userland.

Please take a look.

Best regards,
								Pavel
-- 
I don't work for Nazis and criminals, and neither should you.
Boycott Putin, Trump, and Musk!

Download attachment "signature.asc" of type "application/pgp-signature" (196 bytes)