linux-kernel - Re: [PATCH] regulator: max20086: Fix refcount leak in max20086_parse_regulators

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250527121522.GN12492@pendragon.ideasonboard.com>
Date: Tue, 27 May 2025 14:15:22 +0200
From: Laurent Pinchart <laurent.pinchart@...asonboard.com>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: Cosmin Tanislav <demonsingur@...il.com>,
	Liam Girdwood <lgirdwood@...il.com>,
	Mark Brown <broonie@...nel.org>, linux-kernel@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] regulator: max20086: Fix refcount leak in
 max20086_parse_regulators_dt()

Hi Dan,

Thank you for the patch.

On Tue, May 27, 2025 at 08:44:14AM +0300, Dan Carpenter wrote:
> There is a missing call to of_node_put() if devm_kcalloc() fails.
> Fix this by changing the code to use cleanup.h magic to drop the
> refcount.
> 
> Fixes: 6b0cd72757c6 ("regulator: max20086: fix invalid memory access")
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>

Reviewed-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>

> ---
>  drivers/regulator/max20086-regulator.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/regulator/max20086-regulator.c b/drivers/regulator/max20086-regulator.c
> index b4fe76e33ff2..fcdd2d0317a5 100644
> --- a/drivers/regulator/max20086-regulator.c
> +++ b/drivers/regulator/max20086-regulator.c
> @@ -5,6 +5,7 @@
>  // Copyright (C) 2022 Laurent Pinchart <laurent.pinchart@...sonboard.com>
>  // Copyright (C) 2018 Avnet, Inc.
>  
> +#include <linux/cleanup.h>
>  #include <linux/err.h>
>  #include <linux/gpio/consumer.h>
>  #include <linux/i2c.h>
> @@ -133,11 +134,11 @@ static int max20086_regulators_register(struct max20086 *chip)
>  static int max20086_parse_regulators_dt(struct max20086 *chip, bool *boot_on)
>  {
>  	struct of_regulator_match *matches;
> -	struct device_node *node;
>  	unsigned int i;
>  	int ret;
>  
> -	node = of_get_child_by_name(chip->dev->of_node, "regulators");
> +	struct device_node *node __free(device_node) =
> +		of_get_child_by_name(chip->dev->of_node, "regulators");
>  	if (!node) {
>  		dev_err(chip->dev, "regulators node not found\n");
>  		return -ENODEV;
> @@ -153,7 +154,6 @@ static int max20086_parse_regulators_dt(struct max20086 *chip, bool *boot_on)
>  
>  	ret = of_regulator_match(chip->dev, node, matches,
>  				 chip->info->num_outputs);
> -	of_node_put(node);
>  	if (ret < 0) {
>  		dev_err(chip->dev, "Failed to match regulators\n");
>  		return -EINVAL;
-- 
Regards,

Laurent Pinchart