linux-kernel - Re: [PATCH v12 20/21] selftests/futex: Add futex_priv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <269b2f41-1405-4cab-9310-11df428e64c6@sirena.org.uk>
Date: Tue, 27 May 2025 13:59:38 +0100
From: Mark Brown <broonie@...nel.org>
To: Sebastian Andrzej Siewior <bigeasy@...utronix.de>
Cc: linux-kernel@...r.kernel.org,
	André Almeida <andrealmeid@...lia.com>,
	Darren Hart <dvhart@...radead.org>,
	Davidlohr Bueso <dave@...olabs.net>, Ingo Molnar <mingo@...hat.com>,
	Juri Lelli <juri.lelli@...hat.com>,
	Peter Zijlstra <peterz@...radead.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Valentin Schneider <vschneid@...hat.com>,
	Waiman Long <longman@...hat.com>
Subject: Re: [PATCH v12 20/21] selftests/futex: Add futex_priv_hash

On Tue, May 27, 2025 at 02:43:27PM +0200, Sebastian Andrzej Siewior wrote:
> On 2025-05-27 13:35:50 [+0100], Mark Brown wrote:

> > Yeah, I was a bit confused as well.  This is running with an installed
> > copy of the selftests and IIRC the build is out of tree so it's possible
> > something is different with that path compared to what you're doing?
> > It's a common source of problems?

> It shouldn't be. The test is self-contained and as long as the run.sh
> script invokes all is good.  I don't see what futex_priv_hash might be
> is doing different compared to the previous test.

> I just noticed that after the two futex_priv_hash invocations there
> should be one futex_numa_mpol invocation. That one is missing in the
> output. Any idea why?

I'm not seeing that test being built or in the binary:

   https://builds.sirena.org.uk/cda95faef7bcf26ba3f54c3cddce66d50116d146/arm64/defconfig/build.log
   https://builds.sirena.org.uk/cda95faef7bcf26ba3f54c3cddce66d50116d146/arm64/defconfig/kselftest.tar.xz

(note that this is the specific commit that I'm replying to the patch
for, not -next.)  It looks like it's something's getting mistbuilt or
there's some logic bug with the argument parsing, if I run the binary
with -h it exits with return code 0 rather than 1.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)