linux-kernel - Re: [PATCH 1/5] dt-bindings: net: qca,ar803x: Add IPQ5018 Internal GE PHY support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0c57cff8-c730-49cd-b056-ce8fd17c5253@lunn.ch>
Date: Tue, 27 May 2025 15:08:19 +0200
From: Andrew Lunn <andrew@...n.ch>
To: George Moussalem <george.moussalem@...look.com>
Cc: Konrad Dybcio <konrad.dybcio@....qualcomm.com>,
	Krzysztof Kozlowski <krzk@...nel.org>,
	Heiner Kallweit <hkallweit1@...il.com>,
	Russell King <linux@...linux.org.uk>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Florian Fainelli <f.fainelli@...il.com>,
	Philipp Zabel <p.zabel@...gutronix.de>,
	Bjorn Andersson <andersson@...nel.org>,
	Konrad Dybcio <konradybcio@...nel.org>,
	Michael Turquette <mturquette@...libre.com>,
	Stephen Boyd <sboyd@...nel.org>, netdev@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-arm-msm@...r.kernel.org, linux-clk@...r.kernel.org
Subject: Re: [PATCH 1/5] dt-bindings: net: qca,ar803x: Add IPQ5018 Internal
 GE PHY support

> > > > > > Would qcom,phy-to-phy-dac (boolean) do?
> > > > > 
> > > > > Seems fine to me.
> > > > 
> > > > Can the driver instead check for a phy reference?
> > > 
> > > Do you mean using the existing phy-handle DT property or create a new DT property called 'qcom,phy-reference'? Either way, can add it for v2.
> > 
> > I'm not sure how this is all wired up. Do you have an example of a DT
> > with both configurations you described in your reply to Andrew?

When a SoC interface is connected to a switch, the SoC interface has
no real knowledge it is actually connected to a switch. All it knows
is it has a link peer, and it does not know if that peer is 1cm away
or 100m. It does nothing different.

The switch has a phandle to the SoC interface, so it knows a bit more,
but it would be a bit around about for the SoC interface to search the
whole device tree to see if there is a switch with a phandle pointing
to it. So for me, a bool property indicating a short 'cable' is the
better solution.

	Andrew