linux-kernel - Re: [PATCH next] ACPI: APEI: EINJ: Clean up on error in einj

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJZ5v0im_642kBUqryy=70-+JikM+dhg=w=Shc3Df4HKPhDCsA@mail.gmail.com>
Date: Tue, 27 May 2025 15:21:07 +0200
From: "Rafael J. Wysocki" <rafael@...nel.org>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: Zaid Alali <zaidal@...amperecomputing.com>, "Rafael J. Wysocki" <rafael@...nel.org>, 
	Len Brown <lenb@...nel.org>, James Morse <james.morse@....com>, Tony Luck <tony.luck@...el.com>, 
	Borislav Petkov <bp@...en8.de>, Sudeep Holla <sudeep.holla@....com>, 
	Jonathan Cameron <Jonathan.Cameron@...wei.com>, 
	Uwe Kleine-König <u.kleine-koenig@...libre.com>, 
	Jon Hunter <jonathanh@...dia.com>, Ira Weiny <ira.weiny@...el.com>, linux-acpi@...r.kernel.org, 
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH next] ACPI: APEI: EINJ: Clean up on error in einj_probe()

On Tue, May 27, 2025 at 7:43 AM Dan Carpenter <dan.carpenter@...aro.org> wrote:
>
> Call acpi_put_table() before returning the error code.
>
> Fixes: e54b1dc1c4f0 ("ACPI: APEI: EINJ: Remove redundant calls to einj_get_available_error_type()")
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>
> ---
>  drivers/acpi/apei/einj-core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/apei/einj-core.c b/drivers/acpi/apei/einj-core.c
> index ca3484dac5c4..fea11a35eea3 100644
> --- a/drivers/acpi/apei/einj-core.c
> +++ b/drivers/acpi/apei/einj-core.c
> @@ -766,7 +766,7 @@ static int __init einj_probe(struct faux_device *fdev)
>
>         rc = einj_get_available_error_type(&available_error_type);
>         if (rc)
> -               return rc;
> +               goto err_put_table;
>
>         rc = -ENOMEM;
>         einj_debug_dir = debugfs_create_dir("einj", apei_get_debugfs_dir());
> --

Applied, thanks!