linux-kernel - Re: [PATCH next] ACPI: MRRM: Silence error code static checker warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJZ5v0hWKbC2eEe-ce55PN0k4bYnPJ3D+AdPgxJNAcr8Q6rkGQ@mail.gmail.com>
Date: Tue, 27 May 2025 15:24:00 +0200
From: "Rafael J. Wysocki" <rafael@...nel.org>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: Tony Luck <tony.luck@...el.com>, "Rafael J. Wysocki" <rafael@...nel.org>, Len Brown <lenb@...nel.org>, 
	linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org, 
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH next] ACPI: MRRM: Silence error code static checker warning

On Tue, May 27, 2025 at 7:54 AM Dan Carpenter <dan.carpenter@...aro.org> wrote:
>
> The error code is not set correctly on if kasprintf() fails.  On the
> first iteration it would return -EINVAL and subsequent iterations
> would return success.  Set it to -ENOMEM.
>
> In real life, this allocation will not fail and if it did the system
> will not boot so this change is mostly to silence static checker warnings
> more than anything else.
>
> Fixes: 04f53540f791 ("ACPI: MRRM: Add /sys files to describe memory ranges")
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>
> ---
>  drivers/acpi/acpi_mrrm.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/acpi_mrrm.c b/drivers/acpi/acpi_mrrm.c
> index 2f22f013959a..70088cdfde13 100644
> --- a/drivers/acpi/acpi_mrrm.c
> +++ b/drivers/acpi/acpi_mrrm.c
> @@ -156,8 +156,10 @@ static __init int add_boot_memory_ranges(void)
>
>         for (int i = 0; i < mrrm_mem_entry_num; i++) {
>                 name = kasprintf(GFP_KERNEL, "range%d", i);
> -               if (!name)
> +               if (!name) {
> +                       ret = -ENOMEM;
>                         break;
> +               }
>
>                 kobj = kobject_create_and_add(name, pkobj);
>
> --

Applied, thanks!